Fix #41 - Add cancelDownload function to DownloadManager #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add cancelDownload() function to cancel a iternal download item.
arthurlee
changed the title
arthurlee
changed the title
danielnieto
reviewed
Jan 8, 2020
| request.on('login', options.onLogin) | ||
| } else if (options.username && options.password) { | ||
| request.on('login', (authInfo, callback) => { | ||
| callback(options.username, options.password) |
Owner
There was a problem hiding this comment.
I don't think these changes are relevant to 'abort download' functionality, correct me if I'm wrong
danielnieto
requested changes
Jan 8, 2020
Owner
danielnieto
left a comment
danielnieto
left a comment
There was a problem hiding this comment.
Could you split all the functionality for aborting a download into a single PR and another for the other functionality related to authentication? please, thank you for your collaboration
|
Hi there, thanks for all your good Work. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cancelDownload() function to cancel a iternal download item.