test(e2e): verify #794 house_arrest VendDocuments fallback on App Store apps - #822
Open
danielpaulus wants to merge 1 commit into
Open
test(e2e): verify #794 house_arrest VendDocuments fallback on App Store apps#822danielpaulus wants to merge 1 commit into
danielpaulus wants to merge 1 commit into
Conversation
…re apps Adds a real-device e2e test (behind the e2e build tag) that classifies installed user apps via installationproxy and, for an App Store app (User type without the get-task-allow entitlement), calls house_arrest.New and asserts it succeeds and returns a usable AFC connection — proving PR #794's VendContainer -> VendDocuments fallback. Also exercises a developer-signed app to prove the VendContainer path did not regress. Skips loudly when no App Store app is installed on a device, since the fallback cannot be exercised without one. Non-destructive: read-only directory listing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J8eMENxJ1nec9CeHp4tjWk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a real-device e2e test (
test/e2e/house_arrest_test.go, behind thee2ebuild tag) that verifies PR #794 — thehouse_arrestVendContainer→VendDocumentsfallback for App Store apps. This is a verification test only; it does not touchhouse_arrest.goor any other code.The unit tests can't exercise the fallback: CI's apps are developer-signed, so
VendContainersucceeds and the fallback stays dormant. Confirming it needs a real device with an App Store (non-developer-signed) app.What the test does, per configured device
installationproxyand logs the full inventory (bundleID + ApplicationType + whether developer-signed via theget-task-allowentitlement).Userwithoutget-task-allow(the kind that rejectsVendContainerwithInstallationLookupFailed). If found: assertshouse_arrest.Newsucceeds and the returned AFC client canList("/")— proving theVendDocumentsfallback produced a working connection.house_arrest.Newstill works viaVendContainer(no regression).t.Skips with a loud message rather than failing.Non-destructive: read-only directory listing only.
Real-device run result
Dispatched
real-device.ymlagainst this branch — run 31501985638, both jobs green.00008120-...401E: 3 user apps, all developer-signed. VendContainer no-regression path OK. No App Store app → fallback SKIPPED.00008110-...401E: 2 user apps, all developer-signed. VendContainer no-regression path OK. No App Store app → fallback SKIPPED.So the VendContainer happy path is confirmed unbroken on real devices, but the #794 VendDocuments fallback itself is not yet exercised — neither farm device has an App Store app. Installing any free App Store app on a farm device will flip the skip into a real assertion on the next run.
Do not merge without review.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com