Add optional HTTP auth, tests. #297
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the use case here? Are you connecting to the exporter over the public internet? Is it possible to place Nginx in front? |
|
I am running the container in AWS. I am scraping using grafana.com cloud
account (which for some reason requires authentication). I can place
anything I want in front, however, that would cost me more $$ with AWS.
…On Sat, Mar 2, 2024 at 1:28 PM Dani Hodovic ***@***.***> wrote:
What's the use case here? Are you connecting to the exporter over the
public internet? Is it possible to place Nginx in front?
—
Reply to this email directly, view it on GitHub
<#297 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFDMVQ6GEPBQJET3QYL4QTYWIK6BAVCNFSM6AAAAABECBXNUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZUHA3TEMJUGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
This is the first request I receive for baking in HTTP basic auth. I'd prefer to keep the code base small so I won't be merging this. Feel free to fork the repo with the added changes and deploy your own patched exporter. If you're using Grafana for visualizations here are two charts designed for the exporter: |
|
I've changed my mind. I think we can merge this. Can you resolve the conflicts and I will take a look? |
|
Sure thing. |
bgirschig
reviewed
Aug 26, 2025
Comment on lines
+130
to
+135
| @click.option( | ||
| "--http-username", default=None, help="Basic auth username for /metrics endpoint." | ||
| ) | ||
| @click.option( | ||
| "--http-password", default=None, help="Basic auth password for /metrics endpoint." | ||
| ) |
There was a problem hiding this comment.
Would it be possible to add an envvar to these ? I want to avoid passwords in commands
Suggested change
| @click.option( | |
| "--http-username", default=None, help="Basic auth username for /metrics endpoint." | |
| ) | |
| @click.option( | |
| "--http-password", default=None, help="Basic auth password for /metrics endpoint." | |
| ) | |
| @click.option( | |
| "--http-username", | |
| default=None, | |
| help="Basic auth username for /metrics endpoint.", | |
| envvar="CELERY_EXPORTER_HTTP_USERNAME" | |
| ) | |
| @click.option( | |
| "--http-password", | |
| default=None, | |
| help="Basic auth password for /metrics endpoint.", | |
| envvar="CELERY_EXPORTER_HTTP_PASSWORD" | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed HTTP basic auth for my metrics. This PR adds two optional CLI args:
--http-usernameand--http-password.