Fix theme parser errors #170
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following warnings: Theme parser error: gtk.css:5050:12-15: "mix" is not a valid color name. Theme parser error: gtk.css:5054:12-15: "mix" is not a valid color name. Apparently there should be no space between function name and the opening parentheses. The fix was originally done by Matthew Fay in his fork: https://github.com/nullorigin/flat-remix-gtk We will fix the main file and regenerate the themes later. Suggested-by: Matthew Fay <[email protected]> Signed-off-by: Siddh Raman Pant <[email protected]>
Fixes the following warnings: Theme parser error: gtk.css:4963:12-17: "shade" is not a valid color name. Theme parser error: gtk.css:5023:12-17: "shade" is not a valid color name. Apparently there should be no space between function name and the opening parentheses. The fix was originally done by Matthew Fay in his fork: https://github.com/nullorigin/flat-remix-gtk We will fix the main files and regenerate the themes later. Suggested-by: Matthew Fay <[email protected]> Signed-off-by: Siddh Raman Pant <[email protected]>
siddhpant
force-pushed
the
fix-parser-errors
branch
2 times, most recently
from
1b460da to
beb963b
Compare
Fixes the following warning: Theme parser error: gtk.css:5286:3-19: No property named "-gtk-icon-effect" Let's complete the TODO mentioned. The fix was originally done by Matthew Fay in his fork: https://github.com/nullorigin/flat-remix-gtk We will be more exact, and fix the main file by doing a sed hack in the sass Makefile, and regenerate the themes later. Suggested-by: Matthew Fay <[email protected]> Signed-off-by: Siddh Raman Pant <[email protected]>
Fixes the following warning:
Theme parser warning: gtk.css:5255:3-5256:1: Expected ';' at end of block
We will fix the main file and regenerate the themes later.
Signed-off-by: Siddh Raman Pant <[email protected]>
Signed-off-by: Siddh Raman Pant <[email protected]>
siddhpant
force-pushed
the
fix-parser-errors
branch
from
beb963b to
5a44f03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @nullorigin for fixing them in his fork, but he replaced in files directly. In this PR I fix it in the generator files and regenerate the themes.