Adding courseinfo to QR Code screen and devcontainer build setup#900
Adding courseinfo to QR Code screen and devcontainer build setup#900mgmodell wants to merge 1 commit into
Conversation
|
Thanks @mgmodell - best to pull out all the devcontainer stuff from the PR if you would like me to consider this - I don't think I've seen that in any moodle plugins and it's not something I'm currently looking at doing. Also - I'm not quite sure if simply adding header tags is enough to make it display well - might be worth you dropping in a screenshot of how it looks into the PR as well? Once that's done, please squash your commits into a single commit - I'm also a strong advocate for people using git commit trailiers when their code has been created with the use of AI tooling. - for example adding something like the following to the end of your commit message: thanks! |
|
Understood @danmarsden . Here's what the current revisions look like. I'm happy to make changes, just let me know what you'd prefer. The page is already pretty simple and this gives me what I needed from it, but I was aiming for functional since I wasn't sure where to look for a design/style guide. Is there one I ought to consult? I generally do not show the password as I use the QR with it embedded: |
|
thanks for adding the screenshot - I think it might look better to remove the "course:" and "Session:" text - just display the course fullname, and then underneath that show the session date. (no need for the session date to show on both lines either) - but other than that - using the header tags looks sufficient for now. |
|
yes - that looks better to me - feel free to send through a new PR with the other changes requested and I'll try to review when I get some spare time. |
9ab3957 to
6a37d0c
Compare
|
I think this meets your request, @danmarsden , but please let me know if it does not. |
|
yeah - pretty close - if you look at the "files changed" tab here in github we only want to see files changed that are part of this fix. you patch inscludes changes to .gitignore, composer.json and composer.lock that shouldn't be there. I'd also be inclined to stop using lang strings and just inject the course fullname and sessiondate eg: also - when printing $course->fullname we need to pass it through format_string in case it has any multi-lang tags etc. |
7c6d8e3 to
c4b5754
Compare
|
How's this, @danmarsden ? |
|
yeah - looks good - I'm just not sure why it hasn't triggered the github actions to run codechecker etc in the PR... There's a small conflict in the version.php file but I can fix that manually - just need to work out why the actions aren't being triggered. |
|
Fantastic! |



This should satisfy #857 .
Full disclosure, I used copilot to help as I was struggling to get the dev environment set up. Therefore, in addition to the small addition to the QR Code screen, we also have. devcontainer setup that's been debugged and verified to work on my M1 mac using vscode. If you have the extension installed, it will build the moodle environment and launch it upon 'reopen in dev container.' There's also a script in the
/scriptsfolder to create a course with a few students and an attendance. That way I was able to launch and test everything pretty quickly.I fiddled a bit with the layout to find something that I like, but it might break some style rules and it's easy enough to change if needed. I suspect most people won't like it as is. Happy to help if so, but this is at least functional.
Finally, not sure the policy on version bumps, but I tried to update it appropriately.