feat: DataTable update + various UI enhancements #9698
Conversation
berry-13
force-pushed
the
feat/components-update
branch
from
a3a3938 to
f161a07
Compare
- Replaced button-based sorting headers in the Chat Input Files Table with a new SortFilterHeader component for better code organization and consistency. - Updated the header for filename, updatedAt, and bytes columns to utilize the new component. Enhance Navigation Component with Skeleton Loading States - Added Skeleton loading states to the Nav component for better user experience during data fetching. - Updated Suspense fallbacks for AgentMarketplaceButton and BookmarkNav components to display Skeletons. Refactor Avatar Component for Improved UI - Enhanced the Avatar component by adding a Label for drag-and-drop functionality. - Improved styling and structure for the file upload area. Update Shared Links Component for Better Error Handling and Sorting - Improved error handling in the Shared Links component for fetching next pages and deleting shared links. - Simplified the header rendering for sorting columns and added sorting functionality to the title and createdAt columns. Refactor Archived Chats Component - Merged ArchivedChats and ArchivedChatsTable components into a single ArchivedChats component for better maintainability. - Implemented sorting and searching functionality with debouncing for improved performance. - Enhanced the UI with better loading states and error handling. Update DataTable Component for Sorting Icons - Added sorting icons (ChevronUp, ChevronDown, ChevronsUpDown) to the DataTable headers for better visual feedback on sorting state. Localization Updates - Updated translation.json to fix missing translations and improve existing ones for better user experience.
…imized features - Added DataTable component with support for virtual scrolling, row selection, and customizable columns. - Introduced hooks for debouncing search input, managing row selection, and calculating column styles. - Enhanced accessibility with keyboard navigation and selection checkboxes. - Implemented skeleton loading state for better user experience during data fetching. - Added DataTableSearch component for filtering data with debounced input. - Created utility logger for improved debugging in development. - Updated translations to support new UI elements and actions.
…tead of hideOnMobile; remove unused DataTableColumnHeader component
…nu, and MCPSubMenu components; update border-radius in style.css
…xpanded state with useEffect
…dChats components; update translation.json with new keys for link actions
…ype definitions; improve cleanup timers and optimize rendering
… and update custom actions renderer type
…ning for missing IDs; streamline DataTableComponents imports
…ization for selection and loading states
… functionality in ArchivedChats and DataTable components
berry-13
force-pushed
the
feat/components-update
branch
from
f45139f to
dfe28c4
Compare
🚨 Unused i18next Keys DetectedThe following translation keys are defined in
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| }, | ||
| ], | ||
| }; | ||
| } catch (err) { |
Check warning
Code scanning / ESLint
Disallow unused variables Warning
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 17 days ago
To fix this issue, we should rename the unused caught error variable in the catch block from err to _err. This satisfies the ESLint rule by making the unused variable explicit, showing that the omission is intentional. The change is limited to lines 226-228 in api/models/Conversation.js, ensuring no changes to existing functionality.
| @@ -223,7 +223,7 @@ | ||
| }, | ||
| ], | ||
| }; | ||
| } catch (err) { | ||
| } catch (_err) { | ||
| logger.warn('[getConvosByCursor] Invalid cursor format, starting from beginning'); | ||
| } | ||
| if (cursorFilter) { |
| { | ||
| accessorKey: 'actions', | ||
| id: 'actions', | ||
| accessorFn: (row: Record<string, unknown>): unknown => null, |
Check warning
Code scanning / ESLint
Disallow unused variables Warning
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 13 days ago
To fix this problem without altering functionality, rename the parameter in the accessorFn at line 250 from row to _row. This signals to ESLint and readers that the parameter is required by the API but intentionally unused in the function's implementation. Only this line needs editing; no additional imports or structural changes are required.
| @@ -247,7 +247,7 @@ | ||
| }, | ||
| { | ||
| id: 'actions', | ||
| accessorFn: (row: Record<string, unknown>): unknown => null, | ||
| accessorFn: (_row: Record<string, unknown>): unknown => null, | ||
| header: () => ( | ||
| <span className="text-xs text-text-primary sm:text-sm"> | ||
| {localize('com_assistants_actions')} |
…from select all button for improved accessibility
🚨 Unused i18next Keys DetectedThe following translation keys are defined in
|
…trings for cleaner localization
… with dynamic overscan adjustments
…emove deprecated features
…; disable row selection
…d improve column visibility handling
1 participant
Summary
Please provide a brief summary of your changes and the related issue. Include any motivation and context that is relevant to your changes. If there are any dependencies necessary for your changes, please list them here.
Change Type
Testing
Test Configuration:
Checklist