Skip to content

state List item #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

state List item #16

wants to merge 4 commits into from

Conversation

Smita81
Copy link
Collaborator

@Smita81 Smita81 commented May 6, 2024

No description provided.

@Smita81 Smita81 requested a review from dannyelcf May 6, 2024 17:15
@Smita81 Smita81 self-assigned this May 6, 2024
import { listHandler } from './handler.js';
import { list } from './util.js';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to import util.js here. You are not using it here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Comment on lines 19 to 22
let stringList = '';
for (const input of allInputs) {
stringList += `\n${bulletPoint} ${input}`;
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must invoke list function here once you implemented it in the util.js

Ex:

const stringList = list(allInputs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants