test code for review #3

Smita81 · 2024-05-06T10:34:03Z

No description provided.

dannyelcf · 2024-05-07T19:17:10Z

0-data-roles/0-one-file/src/constants.js

@@ -0,0 +1,14 @@
+export const INITIAL_STATE = {


Run npm run format to correctly indent the code.

dannyelcf · 2024-05-07T19:18:47Z

0-data-roles/0-one-file/src/handlers.js

@@ -0,0 +1,20 @@
+import { INITIAL_STATE, EVENTS, HTML_CLASSES } from './constants.js';
+const handlers = (EVENTS) => {


The name of the arguments must not be UPPERCASED.

Suggested change

const handlers = (EVENTS) => {

const handlers = (event) => {

dannyelcf · 2024-05-07T19:19:22Z

0-data-roles/0-one-file/src/handlers.js

+const eventsMouseOverHistory = document.getElementById(EVENTS.MOUSE_OVER_HISTORY,);
+    // Handler logic for when the user moves the mouse over 'number-history'
+*/
+    const targetText = EVENTS.target.innerText;


Suggested change

const targetText = EVENTS.target.innerText;

const targetText = event.target.innerText;

dannyelcf · 2024-05-07T19:20:00Z

0-data-roles/0-one-file/src/handlers.js

+
+    backwardsContainer.innerHTML = liString + backwardsContainer.innerHTML;
+
+  if (EVENTS.target.nodeName !== 'LI') {


Suggested change

if (EVENTS.target.nodeName !== 'LI') {

if (event.target.nodeName !== 'LI') {

dannyelcf · 2024-05-07T19:21:19Z

0-data-roles/0-one-file/src/handlers.js

+    return;
+  };
+
+  const liString = `<li class="number-item">${state.currentNumber}</li>`;s


Remove the s at the end of the line.

Suggested change

const liString = `<li class="number-item">${state.currentNumber}</li>`;s

const liString = `<li class="number-item">${state.currentNumber}</li>`;

dannyelcf · 2024-05-07T19:25:31Z

0-data-roles/0-one-file/src/init.js

@@ -1,37 +1,37 @@
 debugger; // once when the program is initialized


Once you have implemented the file listeners.js you must remove all the code inside init.js and import the file listeners.js here.

import './listeners.js'

dannyelcf · 2024-05-07T19:28:42Z

0-data-roles/0-one-file/src/utils.js

+const state = {
+    currentNumber: 0,
+    allNumbers: [],
+  };


This snippet of code must be inside a state.js file.

dannyelcf · 2024-05-07T19:29:27Z

0-data-roles/0-one-file/src/utils.js

+  const nextNumber = Number(inputValue);
+
+  // --- update state ---
+  state.allNumbers.push(nextNumber);
+  state.currentNumber = state.allNumbers.at(-1);


This snippet of code must be inside a handler code.

dannyelcf · 2024-05-07T19:33:09Z

0-data-roles/0-one-file/src/utils.js

@@ -0,0 +1,14 @@
+import { INITIAL_STATE, EVENTS, HTML_CLASSES } from './constants.js';


An utils file must contain exported functions. Here in your file you didn't create any function.

dannyelcf · 2024-05-07T19:34:50Z

5-testing-components/exercises-write-components/game-board/game-board.js

+for (const array of arrayOfArrays) {
+    const tr = document.createElement('tr');
+    table.appendChild(tr);
+    for (const element of array) {
+        const td = document.createElement('td');
+        td.innerText = element;
+        tr.appendChild(td);
+    }
+table.appendChild(tr);
+  }


When we have an arrayOfArrays represeting a table, usually we use names like row and column in the for loops.

Suggested change

for (const array of arrayOfArrays) {

const tr = document.createElement('tr');

table.appendChild(tr);

for (const element of array) {

const td = document.createElement('td');

td.innerText = element;

tr.appendChild(td);

}

table.appendChild(tr);

}

for (const row of arrayOfArrays) {

const tr = document.createElement('tr');

table.appendChild(tr);

for (const column of row) {

const td = document.createElement('td');

td.innerText = column;

tr.appendChild(td);

}

}

dannyelcf · 2024-05-07T19:35:41Z

5-testing-components/exercises-write-components/game-board/game-board.js

+        td.innerText = element;
+        tr.appendChild(td);
+    }
+table.appendChild(tr);


Remove this line. You already did this in the line 12.

dannyelcf · 2024-05-07T19:35:55Z

5-testing-components/exercises-write-components/info/info.js

-  const summaryEl = document.createElement('_');
-  _;
-  _;
+  const summaryEl = document.createElement('summery');


You made a typo here.

Suggested change

const summaryEl = document.createElement('summery');

const summaryEl = document.createElement('summary');

dannyelcf · 2024-05-07T19:38:26Z

exercises/convertTemperature/src/utils/util.js

+} from '../constants.js';
+export const convertedTemperature = (fahrenheitTextList) => {
+  if (!/^[0-9\s]*$/.test(fahrenheitTextList)) {
+    window.alert(MESSAGE_ERROR_NOT_INTEGER);


You defined MESSAGE_ERROR_NOT_INTEGER constant as The '%S' contains values different of integer numbers.

So, in the window.alert you must replace the %S by fahrenheitTextList content. For example:

window.alert(MESSAGE_ERROR_NOT_INTEGER.replace('%S', fahrenheitTextList));

dannyelcf · 2024-05-07T19:39:04Z

exercises/convertTemperature/src/utils/util.js

+  var convertedTemperatures = '';
+  fahrenheitList.forEach((fahrenheit) => {
+    // Do the math
+    const celsius = ((fahrenheit - 32) * 5) / 9;
+    convertedTemperatures = convertedTemperatures + ' ' + celsius.toFixed(2);
+  });
+  return convertedTemperatures;


Don't use var. It is not recommeded anymore. Use let or const.

Tip: use map and join functions. This will avoid the empty space at the beginning of the returned convertedTemperatures.

Suggested change

var convertedTemperatures = '';

fahrenheitList.forEach((fahrenheit) => {

// Do the math

const celsius = ((fahrenheit - 32) * 5) / 9;

convertedTemperatures = convertedTemperatures + ' ' + celsius.toFixed(2);

});

return convertedTemperatures;

const convertedTemperatures = fahrenheitList.map((fahrenheit) => {

const celsius = ((fahrenheit - 32) * 5) / 9;

return celsius.toFixed(2);

}).join(' ');

test code for review

5a5a576

Smita81 self-assigned this May 6, 2024

Smita81 requested review from dannyelcf and pallavisarwar May 6, 2024 10:34

dannyelcf reviewed May 7, 2024

View reviewed changes

Smita81 added 4 commits May 8, 2024 21:25

modified game board

cc7bdd1

modified-exercise

5604dae

modified-exercise-game-board

3b72427

modified-exercise-convert-temp

8688aba

		@@ -0,0 +1,20 @@
		import { INITIAL_STATE, EVENTS, HTML_CLASSES } from './constants.js';
		const handlers = (EVENTS) => {

	const targetText = EVENTS.target.innerText;
	const targetText = event.target.innerText;


		backwardsContainer.innerHTML = liString + backwardsContainer.innerHTML;

		if (EVENTS.target.nodeName !== 'LI') {

	if (EVENTS.target.nodeName !== 'LI') {
	if (event.target.nodeName !== 'LI') {

	const liString = `<li class="number-item">${state.currentNumber}</li>`;s
	const liString = `<li class="number-item">${state.currentNumber}</li>`;

		@@ -1,37 +1,37 @@
		debugger; // once when the program is initialized

		@@ -0,0 +1,14 @@
		import { INITIAL_STATE, EVENTS, HTML_CLASSES } from './constants.js';

	const summaryEl = document.createElement('summery');
	const summaryEl = document.createElement('summary');

test code for review #3

Are you sure you want to change the base?

test code for review #3

Uh oh!

Conversation

Smita81 commented May 6, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dannyelcf May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dannyelcf May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dannyelcf May 7, 2024 •

edited

Loading

dannyelcf May 7, 2024 •

edited

Loading