Skip to content

DAOS-17179 test: Fix stop commands with trailing space (#15993) #16411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release/2.6
Choose a base branch
from
Open

DAOS-17179 test: Fix stop commands with trailing space (#15993) #16411

wants to merge 1 commit into from

Conversation

phender
Copy link
Contributor

@phender phender commented May 19, 2025

Remove any trailing space from cmocka commands to ensure they can be properly stopped in tearDown.

Test-tag: DaosCoreTest DaosCoreTestDfuse CsumErrorLog DaosCoreTestDfs DaosCoreTestNvme CatRecovCoreTest
Skip-unit-tests: true
Skip-fault-injection-test: true

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

@phender
DAOS-17179 test: Fix stop commands with trailing space (#15993)
3dea576 
Remove any trailing space from cmocka commands to ensure they can be
properly stopped in tearDown.

Test-tag: DaosCoreTest DaosCoreTestDfuse CsumErrorLog DaosCoreTestDfs DaosCoreTestNvme CatRecovCoreTest
Skip-unit-tests: true
Skip-fault-injection-test: true

Signed-off-by: Phil Henderson <[email protected]>
@phender phender requested review from a team as code owners May 19, 2025 19:56
@phender phender requested a review from daltonbohning May 19, 2025 19:56
@github-actions GitHub Actions
Copy link

Ticket title is 'Extra spaces in command string causes stop to fail'
Status is 'Awaiting backport'
Labels: 'scrubbed_2.8,testp2'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-17179

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label May 19, 2025
@daosbuild3
Copy link
Collaborator

Test stage Functional Hardware Medium Verbs Provider completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-16411/6/execution/node/979/log

@phender
Copy link
Contributor Author

phender commented Jun 2, 2025

Failures not related to changes in the PR:

@phender phender added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Jun 2, 2025
@phender phender requested a review from a team June 2, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daltonbohning daltonbohning daltonbohning approved these changes

Assignees
No one assigned
Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. priority Ticket has high priority (automatically managed)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phender @daosbuild3 @daltonbohning