Skip to content

DAOS-18945 container: bypass space check in flags tx update (#18365)#18490

Open
kccain wants to merge 1 commit into
release/2.8from
kccain/daos_18945_rel2p8
Open

DAOS-18945 container: bypass space check in flags tx update (#18365)#18490
kccain wants to merge 1 commit into
release/2.8from
kccain/daos_18945_rel2p8

Conversation

@kccain

@kccain kccain commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

When a pool's RDB has reached capacity usage to the point where further rdb_tx_update() can return -DER_NOSPACE, a container destroy operation (though epxecting to free RDB space) may itself encounter -DER_NOSPACE. It is possibly due to cont_destroy() first performing rdb_tx_update() before a second phase cont_destroy_post() performs (space-relieving) operations rdb_tx_delete() and rdb_tx_destroy_kvs().

With this change, convert the container_flags update in cont_destroy() to a "critical" tx update, bypassing RDB free space checks.

Features: container ObjectMetadata

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • Appropriate Functional Test Stages were run.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

When a pool's RDB has reached capacity usage to the point where further
rdb_tx_update() can return -DER_NOSPACE, a container destroy operation
(though epxecting to free RDB space) may itself encounter -DER_NOSPACE.
It is possibly due to cont_destroy() first performing rdb_tx_update()
before a second phase cont_destroy_post() performs (space-relieving)
operations rdb_tx_delete() and rdb_tx_destroy_kvs().

With this change, convert the container_flags update in cont_destroy()
to a "critical" tx update, bypassing RDB free space checks.

Features: container ObjectMetadata

Signed-off-by: Kenneth Cain <kenneth.cain@hpe.com>
@kccain kccain added the clean-cherry-pick Cherry-pick from another branch that did not require additional edits label Jun 12, 2026
@github-actions

Copy link
Copy Markdown

Ticket title is 'server/metadata.py:ObjectMetadata.test_metadata_fillup_svc_ops_disabled - failed to destroy container: DER_NOSPACE'
Status is 'In Review'
Labels: 'ci_master_weekly,weekly_test'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-18945

@github-actions github-actions Bot added the priority Ticket has high priority (automatically managed) label Jun 12, 2026
@kccain kccain marked this pull request as ready for review June 15, 2026 10:52
@kccain kccain requested review from a team as code owners June 15, 2026 10:52
@kccain kccain requested review from liw and wangshilong June 15, 2026 10:53
@kccain kccain requested a review from a team June 15, 2026 12:34
@daosbuild3

Copy link
Copy Markdown
Collaborator

Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18490/1/execution/node/1459/log

@daltonbohning daltonbohning added this to the release-2.8 milestone Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean-cherry-pick Cherry-pick from another branch that did not require additional edits priority Ticket has high priority (automatically managed)

Development

Successfully merging this pull request may close these issues.

5 participants