DAOS-19205 control: Improve dmg system rebuild-stop output (#18538)#18690
Open
tanabarr wants to merge 1 commit into
Open
DAOS-19205 control: Improve dmg system rebuild-stop output (#18538)#18690tanabarr wants to merge 1 commit into
tanabarr wants to merge 1 commit into
Conversation
Enhance rebuild-stop command to distinguish between successful stops, pools without active rebuilds (DER_NONEXIST), and actual errors. Provide structured output showing counts for each category and only fail on real errors, not when pools aren't rebuilding. Signed-off-by: Tom Nabarro <thomas.nabarro@hpe.com>
|
Ticket title is 'dmg system rebuild stop command returns DER_NONEXIST error for pools which completed rebuild operation.' |
kjacque
reviewed
Jul 22, 2026
Comment on lines
+28
to
+33
| // extractInfoMessages extracts INFO level messages from a log buffer, returning just | ||
| // the message content without timestamps or prefixes. Returns a single string with | ||
| // messages joined by newlines, terminated with a newline if any messages were found. | ||
| // Continuation lines (lines that don't contain log level markers) are appended to | ||
| // the previous INFO message. | ||
| func extractInfoMessages(logOutput string) string { |
Contributor
There was a problem hiding this comment.
I don't think the output checking is necessary at this level, since the output text is verified down in the pretty package now. Wouldn't be an issue if it was trivial to check, but this parsing logic looks pretty fragile.
Contributor
Author
There was a problem hiding this comment.
As this is a back port is it okay if I revisit this in a follow-on when I next look at this area?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance rebuild-stop command to distinguish between successful stops,
pools without active rebuilds (DER_NONEXIST), and actual errors.
Provide structured output showing counts for each category and only
fail on real errors, not when pools aren't rebuilding.
Steps for the author:
After all prior steps are complete: