DAOS-19333 test: Allow NLT memcheck on release builds#18709
Draft
mjmac wants to merge 1 commit into
Draft
Conversation
|
Ticket title is 'NLT can not be run with release binary' |
The work in DAOS-19102 added a requirement for Go binaries to have been built with valgrind instrumentation in order to be used in the memcheck stage. Release builds intentionally do not include the valgrind instrumentation because it is very slow. This commit refactors the valgrind integration to centralize the logic for deciding whether or not to run with valgrind depending on the requested memcheck mode and the binary under test. It also changes non-release builds to explicitly request memcheck for all Go binaries so that NLT will fail as intended if run against an uninstrumented Go binary. Signed-off-by: Michael MacDonald <github@macdonald.cx>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The work in DAOS-19102 added a requirement for Go binaries
to have been built with valgrind instrumentation in order
to be used in the memcheck stage. Release builds intentionally
do not include the valgrind instrumentation because it is
very slow. Rather than failing outright, the default memcheck
mode (some) now adapts to the build: untagged Go binaries skip
memcheck while dfuse/engine/cart coverage is preserved.
Signed-off-by: Michael MacDonald github@macdonald.cx