Skip to content

Gas optimization #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaustubhthakur wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Gas optimization #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions contracts/Decentratwitter.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ contract Decentratwitter is ERC721URIStorage {
constructor() ERC721("Decentratwitter", "DAPP") {}

function mint(string memory _tokenURI) external returns (uint256) {
tokenCount++;
++tokenCount;
_safeMint(msg.sender, tokenCount);
_setTokenURI(tokenCount, _tokenURI);
setProfile(tokenCount);
Expand All @@ -67,7 +67,7 @@ contract Decentratwitter is ERC721URIStorage {
// Make sure the post hash exists
require(bytes(_postHash).length > 0, "Cannot pass an empty hash");
// Increment post count
postCount++;
++postCount;
// Add post to the contract
posts[postCount] = Post(postCount, _postHash, 0, payable(msg.sender));
// Trigger an event
Expand All @@ -93,7 +93,7 @@ contract Decentratwitter is ERC721URIStorage {
// Fetches all the posts
function getAllPosts() external view returns (Post[] memory _posts) {
_posts = new Post[](postCount);
for (uint256 i = 0; i < _posts.length; i++) {
for (uint256 i = 0; i < _posts.length; ++i) {
_posts[i] = posts[i + 1];
}
}
Expand All @@ -103,10 +103,10 @@ contract Decentratwitter is ERC721URIStorage {
_ids = new uint256[](balanceOf(msg.sender));
uint256 currentIndex;
uint256 _tokenCount = tokenCount;
for (uint256 i = 0; i < _tokenCount; i++) {
for (uint256 i = 0; i < _tokenCount; ++i) {
if (ownerOf(i + 1) == msg.sender) {
_ids[currentIndex] = i + 1;
currentIndex++;
++currentIndex;
}
}
}
Expand Down