Skip to content

test(utils): fix tests that assert nothing and run them in CI #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ihopenre-eng wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test(utils): fix tests that assert nothing and run them in CI #1680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ test-deps:
################################################################################
.PHONY: test
test: test-deps
gotestsum --jsonfile $(TEST_OUTPUT_FILE) --format standard-quiet -- ./pkg/... $(COVERAGE_OPTS)
gotestsum --jsonfile $(TEST_OUTPUT_FILE) --format standard-quiet -- ./pkg/... ./utils/... $(COVERAGE_OPTS)

################################################################################
# E2E Tests for Kubernetes #
Expand Down
20 changes: 16 additions & 4 deletions utils/utils_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,9 @@ func TestGetVersionAndImageVariant(t *testing.T) {

func TestValidateFilePaths(t *testing.T) {
dirName := createTempDir(t, "test_validate_paths")
defer cleanupTempDir(t, dirName)
t.Cleanup(func() {
cleanupTempDir(t, dirName)
})
validFile := createTempFile(t, dirName, "valid_test_file.yaml")
testcases := []struct {
name string
Expand Down Expand Up @@ -212,6 +214,14 @@ func TestGetAbsPath(t *testing.T) {
assert.NoError(t, err)
baseDir := filepath.Dir(ex)

// An absolute path is platform specific: on Windows a rooted path such as
// "/absolute/path" carries no volume name, so filepath.IsAbs reports false
// for it and GetAbsPath joins it with baseDir instead of returning it.
absolutePath := "/absolute/path"
if runtime.GOOS == "windows" {
absolutePath = `C:\absolute\path`
}

testcases := []struct {
name string
input string
Expand All @@ -234,8 +244,8 @@ func TestGetAbsPath(t *testing.T) {
},
{
name: "absolute path",
input: "/absolute/path",
expected: "/absolute/path",
input: absolutePath,
expected: absolutePath,
},
}

Expand Down Expand Up @@ -311,7 +321,9 @@ func TestResolveHomeDir(t *testing.T) {

func TestReadFile(t *testing.T) {
fileName := createTempFile(t, "", "test_read_file")
defer cleanupTempDir(t, fileName)
t.Cleanup(func() {
cleanupTempDir(t, fileName)
})
testcases := []struct {
name string
input string
Expand Down