Skip to content

Conversation

@jslatten
Copy link
Contributor

Description

Added enhancement to enable compression in Pulsar pub/sub component.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #4147

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.

Copilot AI review requested due to automatic review settings December 23, 2025 22:52
@jslatten jslatten requested review from a team as code owners December 23, 2025 22:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the DAPR Pulsar pub/sub component by adding message compression support, allowing users to configure compression type (none, lz4, zlib, zstd) and compression level (default, faster, better) for published messages.

  • Adds two new metadata fields: compressionType and compressionLevel
  • Implements parsing and validation functions following existing code patterns
  • Provides comprehensive test coverage for the new functionality

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
pubsub/pulsar/metadata.go Adds CompressionType and CompressionLevel fields to pulsarMetadata struct
pubsub/pulsar/pulsar.go Implements compression configuration parsing, validation, and integration into producer options
pubsub/pulsar/pulsar_test.go Adds comprehensive tests for compression type, level, and their combinations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jslatten
Copy link
Contributor Author

jslatten commented Jan 7, 2026

@yaron2 The merge seems to be blocked by a failed test with an unrelated component code (Kafka). Can someone please check whether the workflow or test is actually functioning as expected?

@yaron2
Copy link
Member

yaron2 commented Jan 8, 2026

@yaron2 The merge seems to be blocked by a failed test with an unrelated component code (Kafka). Can someone please check whether the workflow or test is actually functioning as expected?

All checks pass now

@jslatten
Copy link
Contributor Author

jslatten commented Jan 8, 2026

@yaron2 Thank you!

Copy link
Contributor

@sicoyle sicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@sicoyle sicoyle added this pull request to the merge queue Jan 8, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2026
@yaron2 yaron2 merged commit a4dd464 into dapr:main Jan 9, 2026
125 of 126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DAPR Pulsar Pub/Sub missing compression parameters

4 participants