-
Notifications
You must be signed in to change notification settings - Fork 548
Enhance DAPR Pulsar pub/sub component to enable message compression #4148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the DAPR Pulsar pub/sub component by adding message compression support, allowing users to configure compression type (none, lz4, zlib, zstd) and compression level (default, faster, better) for published messages.
- Adds two new metadata fields:
compressionTypeandcompressionLevel - Implements parsing and validation functions following existing code patterns
- Provides comprehensive test coverage for the new functionality
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pubsub/pulsar/metadata.go | Adds CompressionType and CompressionLevel fields to pulsarMetadata struct |
| pubsub/pulsar/pulsar.go | Implements compression configuration parsing, validation, and integration into producer options |
| pubsub/pulsar/pulsar_test.go | Adds comprehensive tests for compression type, level, and their combinations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Justin Slatten <[email protected]>
Signed-off-by: Justin Slatten <[email protected]>
Signed-off-by: Justin Slatten <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Justin Slatten <[email protected]>
|
@yaron2 The merge seems to be blocked by a failed test with an unrelated component code (Kafka). Can someone please check whether the workflow or test is actually functioning as expected? |
All checks pass now |
|
@yaron2 Thank you! |
sicoyle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you!
Description
Added enhancement to enable compression in Pulsar pub/sub component.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #4147
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
Note: We expect contributors to open a corresponding documentation PR in the dapr/docs repository. As the implementer, you are the best person to document your work! Implementation PRs will not be merged until the documentation PR is opened and ready for review.