fix(sftp): resolve connection poisoning with enterprise SFTP servers #4153
+193
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dapr#4078 - Close file handles properly inside mutex-protected closures - Use Lock() instead of RLock() for full operation serialization - Make create/write atomic within mutex protection - Improve shouldReconnect() error classification for SFTP StatusError - Add string matching for wrapped errors (permission denied, not a directory, etc.) - Add unit tests for error classification Signed-off-by: kayaj1009 <[email protected]>
Comment on lines
204
to
208
| func (c *Client) do(fn func() error) error { | ||
| c.lock.RLock() | ||
| defer c.lock.RUnlock() | ||
| c.lock.Lock() | ||
| defer c.lock.Unlock() | ||
| return fn() | ||
| } |
Contributor
There was a problem hiding this comment.
@kayaj1009 I think we should go with a configurable approach as not all sftp server needs this strict sync. Probably better if you add a component config to set strict to true in case you need it. Then we should have do and doStrict funcs and use them based on config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes SFTP connection poisoning and concurrent race conditions when using the SFTP binding with enterprise SFTP servers like Axway MFT.
Changes
Lock()instead ofRLock()for full operation serialization - Prevents concurrent operations that confuse strict SFTP serversshouldReconnect()error classification - Properly detectsStatusErrortypes viaerrors.As()to avoid unnecessary reconnection attemptsshouldReconnect()logicIssue reference
Fixes #4078
Checklist