Conversation
Signed-off-by: Prinson Fernandes <prinsonf77@gmail.com>
Signed-off-by: Prinson Fernandes <prinsonf77@gmail.com>
cicoyle
left a comment
cicoyle
left a comment
There was a problem hiding this comment.
Hey! Thanks for the PR here 🎉
Can you confirm that we don't need any additional logic to additionally support passing baggage in as headers? Dapr supports both ctx propagation and header propagation for consistency with tracing.
It might also be worth adding a tracing example to the repo showing how a user may use this, but at the very least we will want to add docs to the daprdocs directory
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #735 +/- ##
==========================================
- Coverage 62.52% 57.16% -5.37%
==========================================
Files 56 58 +2
Lines 4139 4354 +215
==========================================
- Hits 2588 2489 -99
- Misses 1425 1736 +311
- Partials 126 129 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@mikeee Can you please look at this? 🙏 |
mikeee
left a comment
mikeee
left a comment
There was a problem hiding this comment.
First pass, also agree with Cassie's comment. Feel free to ping if you need some help getting this over the finish line 😁
| metadata, ok := metadata.FromOutgoingContext(ctx) | ||
| require.True(t, ok) | ||
| baggageString := metadata.Get(baggageHeader) | ||
| require.Equal(t, []string{"key1=value1,key2=value2"}, baggageString) |
There was a problem hiding this comment.
Do you think it would be pertinent to make this test accommodating of the non deterministic nature of the keys?
This test will be flaky otherwise
4 participants
Description
The dapr runtime has added support for baggage propagation.
This PR allows for the users of the Dapr Go SDK to add baggage to the GRPC client, without having to import OpenTelemetry themselves.
Issue reference
Please reference the issue this PR will close: Issue 718
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: