Skip to content

Separate Dapr constants from IT container constants #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

artur-ciocanu
Copy link
Contributor

Description

This is a tiny follow up PR for #1299

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1299

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@artur-ciocanu artur-ciocanu requested review from a team as code owners April 18, 2025 23:10
@artur-ciocanu
Copy link
Contributor Author

@cicoyle this is a PR to cleanup things a little, so we keep Dapr Testcontainers constants separated from the containers we might use use ITs.

Could you please take a look and approve?

Copy link
Contributor

@siri-varma siri-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thx

@cicoyle cicoyle merged commit 67c5991 into dapr:master Apr 22, 2025
8 of 9 checks passed
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.87%. Comparing base (d759c53) to head (1f2ceb5).
Report is 131 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1315      +/-   ##
============================================
- Coverage     76.91%   76.87%   -0.04%     
- Complexity     1592     1719     +127     
============================================
  Files           145      200      +55     
  Lines          4843     5272     +429     
  Branches        562      574      +12     
============================================
+ Hits           3725     4053     +328     
- Misses          821      903      +82     
- Partials        297      316      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@artur-ciocanu artur-ciocanu deleted the cleanup-container-constants branch April 22, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants