-
Notifications
You must be signed in to change notification settings - Fork 42
feat: Add subsecond precision to jobs #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JoshVanL
merged 8 commits into
dapr:main
from
javier-aliaga:javi-job-subsecond-precision
Jul 10, 2025
Merged
feat: Add subsecond precision to jobs #129
JoshVanL
merged 8 commits into
dapr:main
from
javier-aliaga:javi-job-subsecond-precision
Jul 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e6dcd63
to
6f44d58
Compare
JoshVanL
previously approved these changes
Jul 8, 2025
@javier-aliaga please resolve conflicts |
Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
832e138
to
5129244
Compare
5129244
to
19a7028
Compare
Signed-off-by: Javier Aliaga <[email protected]>
19a7028
to
acccb26
Compare
nelson-parente
approved these changes
Jul 9, 2025
Signed-off-by: Javier Aliaga <[email protected]>
javier-aliaga
commented
Jul 9, 2025
JoshVanL
requested changes
Jul 9, 2025
Signed-off-by: Javier Aliaga <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
==========================================
- Coverage 79.73% 71.90% -7.84%
==========================================
Files 62 82 +20
Lines 4768 5852 +1084
==========================================
+ Hits 3802 4208 +406
- Misses 811 1473 +662
- Partials 155 171 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Javier Aliaga <[email protected]>
JoshVanL
previously approved these changes
Jul 9, 2025
Signed-off-by: Javier Aliaga <[email protected]>
JoshVanL
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr removes precision from
@every
spec allowing any duration supported byDuration
@every Xms
and@every Yns
are now supportedIssue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: dapr/dapr#8728
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: