Skip to content

Conversation

javier-aliaga
Copy link
Contributor

@javier-aliaga javier-aliaga commented Jul 7, 2025

Description

This pr removes precision from @every spec allowing any duration supported by Duration

@every Xms and @every Yns are now supported

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: dapr/dapr#8728

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests

@javier-aliaga javier-aliaga force-pushed the javi-job-subsecond-precision branch 4 times, most recently from e6dcd63 to 6f44d58 Compare July 7, 2025 15:13
@javier-aliaga javier-aliaga reopened this Jul 7, 2025
@javier-aliaga javier-aliaga marked this pull request as ready for review July 8, 2025 09:59
@javier-aliaga javier-aliaga requested review from a team as code owners July 8, 2025 09:59
JoshVanL
JoshVanL previously approved these changes Jul 8, 2025
@JoshVanL
Copy link
Contributor

JoshVanL commented Jul 8, 2025

@javier-aliaga please resolve conflicts

Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
@javier-aliaga javier-aliaga force-pushed the javi-job-subsecond-precision branch 3 times, most recently from 832e138 to 5129244 Compare July 9, 2025 07:11
@javier-aliaga javier-aliaga requested a review from JoshVanL July 9, 2025 07:14
@javier-aliaga javier-aliaga force-pushed the javi-job-subsecond-precision branch from 5129244 to 19a7028 Compare July 9, 2025 08:05
@javier-aliaga javier-aliaga force-pushed the javi-job-subsecond-precision branch from 19a7028 to acccb26 Compare July 9, 2025 08:08
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.90%. Comparing base (26b564d) to head (fc17e64).
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   79.73%   71.90%   -7.84%     
==========================================
  Files          62       82      +20     
  Lines        4768     5852    +1084     
==========================================
+ Hits         3802     4208     +406     
- Misses        811     1473     +662     
- Partials      155      171      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@javier-aliaga javier-aliaga requested a review from JoshVanL July 9, 2025 13:57
JoshVanL
JoshVanL previously approved these changes Jul 9, 2025
@JoshVanL JoshVanL merged commit 9d4f384 into dapr:main Jul 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add sub-second precision to Jobs and Reminders

4 participants