events/loop: Factory & reduce lock contention #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the loop implementation to use an optimistic RLock for enqueueing, falling back to a full Lock only when the queue segment is full. This reduces lock contention. Uses a generic typed Factory to allow for the loop to be sync.Pool cached by the consumer, on demand. The loop does not cache itself as the loop may continue to be used after being closed. Signed-off-by: joshvanl <[email protected]>
JoshVanL
added a commit
to JoshVanL/go-etcd-cron
that referenced
this pull request
Nov 21, 2025
Update github.com/dapr/kit to use the new Loop Factory implementation, improving lock contention. Uses fork dapr/kit#140 Signed-off-by: joshvanl <[email protected]>
JoshVanL
added a commit
to JoshVanL/dapr
that referenced
this pull request
Nov 21, 2025
Creates a new control loop 'namespaces' which is used to managing the connection pool for each namespace. This loop enables further implementation of broadcast jobs which require fanning out triggering across a single namespace set. The namespace scoping has been removed from the connections loop stream store. Uses the kit & go-etcd-cron for the kit update to improve memory allocations and lock contention. diagridio/go-etcd-cron#101 dapr/kit#140 Branched from dapr#9200 Does not change behaviour. Signed-off-by: joshvanl <[email protected]>
cicoyle
pushed a commit
to diagridio/go-etcd-cron
that referenced
this pull request
Nov 24, 2025
* kit/events/loop: Use factory Update github.com/dapr/kit to use the new Loop Factory implementation, improving lock contention. Uses fork dapr/kit#140 Signed-off-by: joshvanl <[email protected]> * Update github.com/dapr/kit to ORIGIN HEAD Signed-off-by: joshvanl <[email protected]> * nix update gomod2nix.toml Signed-off-by: joshvanl <[email protected]> * Eventually wait for precision jobs to no longer exist Signed-off-by: joshvanl <[email protected]> --------- Signed-off-by: joshvanl <[email protected]>
JoshVanL
added a commit
to JoshVanL/dapr
that referenced
this pull request
Dec 2, 2025
Creates a new control loop 'namespaces' which is used to managing the connection pool for each namespace. This loop enables further implementation of broadcast jobs which require fanning out triggering across a single namespace set. The namespace scoping has been removed from the connections loop stream store. Uses the kit & go-etcd-cron for the kit update to improve memory allocations and lock contention. diagridio/go-etcd-cron#101 dapr/kit#140 Branched from dapr#9200 Does not change behaviour. Signed-off-by: joshvanl <[email protected]>
JoshVanL
added a commit
to JoshVanL/dapr
that referenced
this pull request
Dec 4, 2025
Creates a new control loop 'namespaces' which is used to managing the connection pool for each namespace. This loop enables further implementation of broadcast jobs which require fanning out triggering across a single namespace set. The namespace scoping has been removed from the connections loop stream store. Uses the kit & go-etcd-cron for the kit update to improve memory allocations and lock contention. diagridio/go-etcd-cron#101 dapr/kit#140 Branched from dapr#9200 Does not change behaviour. Signed-off-by: joshvanl <[email protected]>
JoshVanL
added a commit
to JoshVanL/dapr
that referenced
this pull request
Dec 5, 2025
Creates a new control loop 'namespaces' which is used to managing the connection pool for each namespace. This loop enables further implementation of broadcast jobs which require fanning out triggering across a single namespace set. The namespace scoping has been removed from the connections loop stream store. Uses the kit & go-etcd-cron for the kit update to improve memory allocations and lock contention. diagridio/go-etcd-cron#101 dapr/kit#140 Branched from dapr#9200 Does not change behaviour. Signed-off-by: joshvanl <[email protected]>
cicoyle
pushed a commit
to dapr/dapr
that referenced
this pull request
Dec 5, 2025
* Scheduler: Namespaces loop Creates a new control loop 'namespaces' which is used to managing the connection pool for each namespace. This loop enables further implementation of broadcast jobs which require fanning out triggering across a single namespace set. The namespace scoping has been removed from the connections loop stream store. Uses the kit & go-etcd-cron for the kit update to improve memory allocations and lock contention. diagridio/go-etcd-cron#101 dapr/kit#140 Branched from #9200 Does not change behaviour. Signed-off-by: joshvanl <[email protected]> * Wait for actors to be registered before retention config not exists Signed-off-by: joshvanl <[email protected]> * Update github.com/dapr/kit to origin HEAD Signed-off-by: joshvanl <[email protected]> * Update github.com/diagridio/go-etcd-cron to point to origin HEAD Signed-off-by: joshvanl <[email protected]> * De-duplicate scheduler logging Signed-off-by: joshvanl <[email protected]> * Update durabletask-go to origin head Signed-off-by: joshvanl <[email protected]> --------- Signed-off-by: joshvanl <[email protected]>
JoshVanL
added a commit
to JoshVanL/dapr
that referenced
this pull request
Dec 5, 2025
Creates a new control loop 'namespaces' which is used to managing the connection pool for each namespace. This loop enables further implementation of broadcast jobs which require fanning out triggering across a single namespace set. The namespace scoping has been removed from the connections loop stream store. Uses the kit & go-etcd-cron for the kit update to improve memory allocations and lock contention. diagridio/go-etcd-cron#101 dapr/kit#140 Branched from dapr#9200 Does not change behaviour. Signed-off-by: joshvanl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the loop implementation to use an optimistic RLock for enqueueing, falling back to a full Lock only when the queue segment is full. This reduces lock contention.
Uses a generic typed Factory to allow for the loop to be sync.Pool cached by the consumer, on demand. The loop does not cache itself as the loop may continue to be used after being closed.