test: cover two untested branches in create_pydantic_model_from_schema - #1203
Open
magic-peach wants to merge 1 commit into
Open
test: cover two untested branches in create_pydantic_model_from_schema#1203magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
…hema The invalid schema to ValueError wrapping path and the array type inside an anyOf variant branch had no test, despite the rest of the file being fairly thorough. Both already worked correctly, ran them before writing the assertions to confirm. Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
create_pydantic_model_from_schemaindapr/ext/workflow/mcp_schema.pyhad two branches with no test coverage despite the rest of the file being fairly thorough: the invalid schema to ValueError wrapping path, and an array type nested inside an anyOf/oneOf variant. Both already worked correctly, ran them before writing the assertions to confirm, this just closes the coverage gap.Issue reference
Please reference the issue this PR will close: # N/A, found while reading mcp_schema.py for test coverage gaps, no existing issue.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: