Test fix: Removing toolchain go* lines that cause midstream downloads
#994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng tests. Signed-off-by: Paul Yuknewicz <[email protected]>
|
good to go @msfussell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened is the go tools inserted toolchain go1.22.0 into go.mod, and that forced the automated test to midstream download go.1.22.0 (because they are based on go 1.21.0) and that is what munged the text output.
This hint was deep in the logs on line 937 where you see
downloading go1.22.0.https://github.com/dapr/quickstarts/actions/runs/8089746951/job/22106150891#step:12:928