Skip to content

Comments

cbor: omit null map entries for Option::None#7

Closed
karalabe wants to merge 1 commit intodark-bio:mainfrom
karalabe:omitmap-opencode-codex
Closed

cbor: omit null map entries for Option::None#7
karalabe wants to merge 1 commit intodark-bio:mainfrom
karalabe:omitmap-opencode-codex

Conversation

@karalabe
Copy link
Member

OpenAI Codex 5.3 via OpenCode. 3:30 min, 42,088 tokens.

Our current CBOR encoder encodes Option<> None as cbor::Null. We only ever used it in array positionals so that's fine. But in maps, this doesn't make sense, we should just omit the field. Lets plan this out , let me confirm, then we can implement it

@karalabe karalabe closed this Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant