[Graphite MQ] Draft PR GROUP:spec_762ef7 (PRs 393, 403)#407
Closed
graphite-app[bot] wants to merge 2 commits into
Closed
[Graphite MQ] Draft PR GROUP:spec_762ef7 (PRs 393, 403)#407graphite-app[bot] wants to merge 2 commits into
graphite-app[bot] wants to merge 2 commits into
Conversation
…t tracking in the filesystem UI (#393) ## Summary When you choose to "track" untracked Homebrew items either individually or as a section, use direct managed edits instead of the agent, which is 1000x faster and more reliable. I should note that it _also_ routes you through the `.nixmac` directory path which the agent generally won't do. This seems like a possible area for a broader discussion @fkb032 @czxtm To enable this, I did some fairly minor refactoring of the existing Homebrew code. So extending this high-level approach to "defaults" and "startup items" will be more work as we'll need to add analogous helper code for it (where it already existed for brew). <!-- What does this PR do? Why? --> ## Test Plan Couple of new unit tests, plus manual testing. - [ ] No test plan needed ## Docs - [ ] Docs updated (companion PR in darkmatter/nixmac-web: #\___) - [x] No docs update needed
## Summary Start swapping out the fake data on the "Untracked" tab of file system view by integrating the same Homebrew diff that the pre-existing chip uses. This involves several changes and refactorings: - Add separate sections for brews/casks/taps simiar to how the chip popup menu works. - Add expanders since in practice some of these sections can get really long (see screenshot). - Fix pre-existing unrelated bug with the brew list command and add logging so it's not totally silent in the future. - Make the "untracked" banner on the begin step delay-loaded and dynamic with the correct count. - Remove the "Track all" button since it never worked right and would work even less right with potentially hundreds of items. We can look into bringing it back once the untracked support is "done". Also see screenshot. The data for "defaults" and "startup items" is still the fake data. I will work on defaults next. Note that there is a lot of demo/AI cruft remaining particularly in data.ts that will continue to disappear the closer we get to the goal. Another potential follow-up item is some caching or limitations on how often we automatically scan, although empirically right now it's not unreasonably slow imo.   <!-- What does this PR do? Why? --> ## Test Plan Some minor updates to unit tests, plus lots of manual testing. Also needed to update a bunch of snaps, hopefully this doesn't run into merge issues etc. - [ ] No test plan needed ## Docs - [ ] Docs updated (companion PR in darkmatter/nixmac-web: #\___) - [x] No docs update needed
Contributor
Contributor
📋 PR Overview
🔬 Coverage
|
graphite-app
Bot
deleted the
gtmq_spec_762ef7_1781308446094-9f780a4d-e320-4874-87e8-bafbc7d6bb8c
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR was created by the Graphite merge queue.
Trunk will be fast forwarded to the HEAD of this PR when CI passes, and the original PRs will be closed.
The following PRs are included in this draft PR: