Attach export ICC profile to JP2 images #18494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TurboGit
added
feature: enhancement
TurboGit
reviewed
Mar 1, 2025
TurboGit
requested changes
Mar 2, 2025
Member
TurboGit
left a comment
TurboGit
left a comment
There was a problem hiding this comment.
Tested and not working on my side, dt quit with:
darktable: ./src/lib/openjp2/jp2.c:831: opj_jp2_write_colr: Assertion jp2->color.icc_profile_len' failed.`
Contributor
Author
|
Thanks for testing. Might be a while until I get to look into this deeper... |
Contributor
Author
Ah, should've checked - it's a known bug already fixed upstream, but very recently. It'll probably take a while until 2.5.4 is released and gets widely distributed, so I guess maybe I'll just gate this code... |
TurboGit
reviewed
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the root cause of #18394