-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix color management issue on windows #20054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Ok, it's updated. |
TurboGit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there :) TIA.
|
@wpferguson : Would you be able to double check this on your Windows build before I merge? Nothing urgent as the merge windows for 5.6 will be open around Jan 19 at best. |
|
@TurboGit I built and it works fine AFAIC see. I can't spin up a second monitor from my VM (maybe libvirt is too old, or I haven't found the correct instructions yet). I could throw the build out on pixls.us and ask for testers. |
Good idea yes. Thanks. |
|
Before i created the PR i tested the original commit (on different system as i use linux). |
|
@Dannny1 : That's reassuring, but when a tricky feature like this is introduced and one that I cannot test myself (I'm not using Windows), I always ask for double checking. |
|
I’m on W11 25H2. NVidia GeForce GTX 1660. 2 monitors from different companies. Using the vendor-supported Windows profiles. WorkingI don’t tend to move darktable between screens. Sometimes I have my display set to use one monitor only (e.g. Windows Show only on 2 display setting). Sometimes I work with both. With production builds, I noticed exported jpg look darker than darktable when using IrfanView (supposedly color-managed). With this build, my exported jpg look like darktable. Using the sRGB profile, perceptual intent. New issue 1I also use the Windows built-in virtual desktops feature. Sometimes I switch to a different desktop if I am doing something else. With this build, the virtual desktops will rotate back to the desktop with darktable intermittently. So far I’ve found two scenarios where this is reproducible. You can rotate to the other desktop for ~5-10 seconds before it rotates back to the desktop where darktable is.
New Issue 2If you are in thumbnail mode and have a window partially covering darktable, darktable will raise to the front (obsuring the window you were working in) if your mouse accidentally passes into a thumbnail Here’s a short video showing both issues
2026-01-11.17-10-35.resize.mp4 |
I assume you tested on the second screen, otherwise it would be irrelevant to the issue. Also the output profile is irrelevant as color management should take care. I was able to reproduce those focus issues, but when i executed with debug "-d all" darktable wasn't taking the focus anymore. So this would be tricky to solve. Not that i would be capable of it anyways as i'm not an expert. From my amateur perspective tho, it seems those functions which determine the correct monitor are read-only, reading os info and should not mess with the focus. However in win32 api anything even bug may be possible (the GetICMProfile function was broken previously for months according to the info i found before Microsoft fixed it). |
|
IrfanView jpg output and darktable look the same on both monitors |
This is just taken from git-db-usr@262b8a6
Since nobody has created PR from it before, i will just open one.