Safe starting without splash #20116
Open
Safe starting without splash #20116
+30
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshannoschwalm
force-pushed
the
starting_no_splash
branch
from
d4d84be to
6ff5d07
Compare
Collaborator
Author
|
@wpferguson would you be able to test for #19992 |
jenshannoschwalm
force-pushed
the
starting_no_splash
branch
from
6ff5d07 to
23d576d
Compare
Contributor
|
It's still crashing for me. Before this PR I noticed that sometimes dt starts one time, but after that it will crash every single start. |
Collaborator
Author
|
Thanks for feedback! What do you mean with crashing exactly? No window appearing without further notice in the logs? |
dterrahe
approved these changes
Jan 11, 2026
Member
dterrahe
left a comment
dterrahe
left a comment
There was a problem hiding this comment.
Apologies; I had a couple of pending comments lined up as in the other PR, but as usual forgot to press the "Finish your review" button.
…0002' As discussed there this was not a fix and added misleading code, so let's revert. Also removed the pthread naming for the jobs as it didn't work correctly and we have the jobs logged anyway.
It's now implemented as an inline function checking for darktable.control == NULL, if so write caller, file and position to the logs. control-last_expose_time was not used at all so it got removed.
1. Wait & process events until window is shown 2. Don't clear *gui struct again
jenshannoschwalm
force-pushed
the
starting_no_splash
branch
from
23d576d to
5d107a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid control threads race conditionAvoid control threads race condition #20002dt_control_running()as an inline function checking fordarktable.controlpossibly logging an errorcontrol->last_expose_timewas not used at all so it got removed.*gui structagaindt_gui_gtk_init()