-
Notifications
You must be signed in to change notification settings - Fork 1.3k
AgX refactoring and preset changes #20120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@kofa73 : This is too big for 5.4.1 and also contains strings changes which cannot be integrated into 5.4.1. Would it be possible to extract from this the fixes, if I'm not mistaken those are:
TIA. |
|
OK, I'll extract those into a separate PR tomorrow. Thanks for the feedback.
|
…ore all controls created; also: remove redundant soft limits (matching hard limits)
… imageop#dt_iop_gui_init
…warnings to gui_update so initial state is painted correctly
…aws into function _update_redraw_dynamic_gui, called from gui_update and gui_changed; extract slider offset, scale, default and value updates into _update_pivot_slider_settings, called from _update_pivot_x (gui_changed and exposure picker callbacks) and from gui_update.
…ed (the idea is to disable (un)rotations and attenuation/purity boost only); use 60% hue preservation for Blender defaults (as that is the Blender default)
…ing _update_redraw_dynamic_gui
…-referred default values
…not indicate an error that must be fixed
|
#20122 for 5.4.1 |
f4fb67a to
4e0ef5c
Compare
Technical changes:
darktable.gui->resetis setgui_updatefromgui_init(agx: Fix crash during initialisation #19745 (comment))gui_changedaftergui_update(agx: Fix crash during initialisation #19745 (comment))_update_redraw_dynamic_gui_update_pivot_slider_settingsDefaults and presets
UI:
Minor:
This PR replaces #19745