Skip to content

agx: clarify in toe/shoulder warning #20133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kofa73 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

agx: clarify in toe/shoulder warning #20133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/iop/agx.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1850,9 +1850,11 @@ static GtkWidget* _create_basic_curve_controls_box(dt_iop_module_t *self,
"higher values keep the slope nearly constant for longer,\n"
"at the cost of a more sudden drop near white"));
dt_bauhaus_widget_set_quad_tooltip(slider,
_("the curve has lost its 'S' shape, shoulder power cannot be applied.\n"
_("shoulder power setting is ineffective, as the curve is no longer S-shaped.\n"
"without inverting the shoulder (forcing it to bend upwards), it would be\n"
"impossible to reach target white with the selected contrast and pivot position.\n"
"this is not an error, the module is still working correctly.\n"
"if you see artifacts, or wish to regain control over the shoulder, try the following:\n"
Copy link
Collaborator

@ralfbrown ralfbrown Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also #20040. I'd recommend turning this final paragraph into a bullet list for readability.

"increase contrast, move the pivot higher (increase pivot target output\n"
"or curve y gamma), or increase the distance between the pivot and the right\n"
"edge (decrease the pivot shift, move the white point farther from the pivot by\n"
Expand All @@ -1867,9 +1869,11 @@ static GtkWidget* _create_basic_curve_controls_box(dt_iop_module_t *self,
"higher values keep the slope nearly constant for longer,\n"
"at the cost of a more sudden drop near black"));
dt_bauhaus_widget_set_quad_tooltip(slider,
_("the curve has lost its 'S' shape, toe power cannot be applied.\n"
_("toe power setting is ineffective, as the curve is no longer S-shaped.\n"
"without inverting the toe (forcing it to bend downwards), it would be\n"
"impossible to reach target black with the selected contrast and pivot position.\n"
"this is not an error, the module is still working correctly.\n"
"if you see artifacts, or wish to regain control over the toe, try the following:\n"
"increase contrast, move the pivot lower (reduce the pivot target output or\n"
"curve y gamma), or increase the distance between the pivot and the left edge\n"
"(increase the pivot shift, move the black point farther from the pivot by raising\n"
Expand Down
Loading