Skip to content

Alternative simple yesno #20138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jenshannoschwalm wants to merge 2 commits into
base: master
Choose a base branch
from
+17 −13
Open

Alternative simple yesno #20138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7330f4e
Two common string macros
jenshannoschwalm Jan 12, 2026
03aedca
Make use of test string macros
jenshannoschwalm Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/darktable.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2468,7 +2468,7 @@ void dt_configure_runtime_performance(const int old, char *info)
dt_conf_set_bool("cache_disk_backend_full", largedisk);
dt_print(DT_DEBUG_DEV,
"[dt_configure_runtime_performance] cache_disk_backend_full=%s",
(largedisk) ? "TRUE" : "FALSE");
STR_TRUEFALSE(largedisk));
}

gboolean updated_mandatory = FALSE;
Expand Down
4 changes: 4 additions & 0 deletions src/common/darktable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,10 @@ G_BEGIN_DECLS
#define __DT_CLONE_TARGETS__
#endif


#define STR_YESNO(b) ((b) ? "YES" : "NO")
#define STR_TRUEFALSE(b) ((b) ? "TRUE" : "FALSE")

typedef int32_t dt_imgid_t;
typedef int32_t dt_filmid_t;
#define NO_IMGID (0)
Expand Down
10 changes: 5 additions & 5 deletions src/common/opencl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,11 +867,11 @@ static gboolean _opencl_device_init(dt_opencl_t *cl,
}

dt_print_nts(DT_DEBUG_OPENCL,
" ASYNC PIXELPIPE: %s\n", cl->dev[dev].asyncmode ? "YES" : "NO");
" ASYNC PIXELPIPE: %s\n", STR_YESNO(cl->dev[dev].asyncmode));
dt_print_nts(DT_DEBUG_OPENCL,
" PINNED MEMORY TRANSFER: %s\n", cl->dev[dev].pinned_memory ? "YES" : "NO");
" PINNED MEMORY TRANSFER: %s\n", STR_YESNO(cl->dev[dev].pinned_memory));
dt_print_nts(DT_DEBUG_OPENCL,
" AVOID ATOMICS: %s\n", cl->dev[dev].avoid_atomics ? "YES" : "NO");
" AVOID ATOMICS: %s\n", STR_YESNO(cl->dev[dev].avoid_atomics));
dt_print_nts(DT_DEBUG_OPENCL,
" MICRO NAP: %i\n", cl->dev[dev].micro_nap);
dt_print_nts(DT_DEBUG_OPENCL,
Expand All @@ -881,7 +881,7 @@ static gboolean _opencl_device_init(dt_opencl_t *cl,
dt_print_nts(DT_DEBUG_OPENCL,
" TILING ADVANTAGE: %.3f\n", cl->dev[dev].advantage);
dt_print_nts(DT_DEBUG_OPENCL,
" DEFAULT DEVICE: %s\n", (type & CL_DEVICE_TYPE_DEFAULT) ? "YES" : "NO");
" DEFAULT DEVICE: %s\n", STR_YESNO(type & CL_DEVICE_TYPE_DEFAULT));

if(cl->dev[dev].disabled)
{
Expand Down Expand Up @@ -1451,7 +1451,7 @@ void dt_opencl_init(dt_opencl_t *cl,
finally:
dt_print(DT_DEBUG_OPENCL,
"[opencl_init] FINALLY: opencl PREFERENCE=%s is %sAVAILABLE and %sENABLED.",
opencl_requested ? "ON" : "OFF",
STR_YESNO(opencl_requested),
cl->inited ? "" : "NOT ",
cl->enabled ? "" : "NOT ");
if(cl->inited && cl->enabled)
Expand Down
6 changes: 3 additions & 3 deletions src/imageio/imageio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,7 +852,7 @@ gboolean dt_imageio_has_mono_preview(const char *filename)

dt_print(DT_DEBUG_IMAGEIO,
"[dt_imageio_has_mono_preview] testing `%s', monochrome=%s, %ix%i",
filename, mono ? "YES" : "FALSE", thumb_width, thumb_height);
filename, STR_YESNO(mono), thumb_width, thumb_height);
dt_free_align(tmp);
return mono;
}
Expand Down Expand Up @@ -1302,8 +1302,8 @@ gboolean dt_imageio_export_with_flags(const dt_imgid_t imgid,
thumbnail_export ? "thumbnail" : "export", imgid,
pipe.processed_width, pipe.processed_height,
processed_width, processed_height, scale, max_scale,
upscale ? "yes" : "no",
high_quality_processing || scale > 1.0f ? "yes" : "no",
STR_YESNO(upscale),
STR_YESNO(high_quality_processing || scale > 1.0f),
dt_check_gimpmode("file") ? " GIMP" : "");

const int bpp = format->bpp(format_params);
Expand Down
2 changes: 1 addition & 1 deletion src/iop/channelmixerrgb.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2042,7 +2042,7 @@ static void _set_trouble_messages(dt_iop_module_t *self)
problem1 ? "white balance applied twice, " : "",
problem2 ? "double CAT applied, " : "",
problem3 ? "white balance missing, " : "",
_dev_is_D65_chroma(dev) ? "YES" : "NO",
STR_YESNO(_dev_is_D65_chroma(dev)),
chr->D65coeffs[0], chr->D65coeffs[1], chr->D65coeffs[2],
chr->as_shot[0], chr->as_shot[1], chr->as_shot[2],
img->id);
Expand Down
6 changes: 3 additions & 3 deletions src/iop/temperature.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1596,9 +1596,9 @@ void reload_defaults(dt_iop_module_t *self)

dt_print(DT_DEBUG_PARAMS,
"[dt_iop_reload_defaults] scene=%s, modern=%s, CAT=%s. D65 %.3f %.3f %.3f, AS-SHOT %.3f %.3f %.3f",
dt_is_scene_referred() ? "YES" : "NO",
is_modern ? "YES" : "NO",
another_cat_defined ? "YES" : "NO",
STR_YESNO(dt_is_scene_referred()),
STR_YESNO(is_modern),
STR_YESNO(another_cat_defined),
daylights[0], daylights[1], daylights[2], as_shot[0], as_shot[1], as_shot[2]);

d->preset = p->preset = DT_IOP_TEMP_AS_SHOT;
Expand Down
Loading