Implement fclonefileat syscall #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zfrdcd
reviewed
Dec 19, 2025
zfrdcd
left a comment
zfrdcd
left a comment
There was a problem hiding this comment.
Nice, I like the idea of copy_file_range.
I used the spec from https://man.freebsd.org/cgi/man.cgi?query=clonefile&apropos=0&sektion=2&manpath=macOS+26.0&arch=default&format=html
I can be more picky if you want , just let me know 👅
darling/src/libsystem_kernel/emulation/src/xnu_syscall/bsd/impl/misc/clonefile.c
Outdated
Show resolved
Hide resolved
darling/src/libsystem_kernel/emulation/src/xnu_syscall/bsd/impl/misc/clonefile.c
Show resolved
Hide resolved
darling/src/libsystem_kernel/emulation/src/xnu_syscall/bsd/impl/unistd/fchown.c
Show resolved
Hide resolved
darling/src/libsystem_kernel/emulation/src/xnu_syscall/bsd/impl/misc/clonefile.c
Outdated
Show resolved
Hide resolved
|
Other than that, I tested it and works for me, Thanks! |
jlucfarias
force-pushed
the
add-fclonefileat-syscall
branch
from
0b2843c to
994bcc5
Compare
Author
|
I've made some substantial changes to make |
|
Mmm I wa
Gonna test it, but i wasn't expected such a big change 🙀 |
|
It worked! Give me a bit more time for reviewing it |
jlucfarias
force-pushed
the
add-fclonefileat-syscall
branch
from
994bcc5 to
c425093
Compare
CuriousTommy
requested changes
Jan 2, 2026
Collaborator
CuriousTommy
left a comment
CuriousTommy
left a comment
There was a problem hiding this comment.
There are some additional issues I haven't commented on yet, but for now, let's focus on the ones I commented on.
darling/src/libsystem_kernel/emulation/include/linux_premigration/linux-syscalls/linux-x86.h
Outdated
Show resolved
Hide resolved
darling/src/libsystem_kernel/emulation/include/linux_premigration/linux-syscalls/linux-x86_64.h
Outdated
Show resolved
Hide resolved
darling/src/libsystem_kernel/emulation/src/xnu_syscall/bsd/impl/misc/clonefile.c
Outdated
Show resolved
Hide resolved
...ing/src/libsystem_kernel/emulation/include/linux_premigration/linux-syscalls/linux-generic.h
Outdated
Show resolved
Hide resolved
darling/src/libsystem_kernel/emulation/src/xnu_syscall/bsd/impl/misc/clonefile.c
Outdated
Show resolved
Hide resolved
darling/src/libsystem_kernel/emulation/src/xnu_syscall/bsd/impl/misc/clonefile.c
Outdated
Show resolved
Hide resolved
darling/src/libsystem_kernel/emulation/src/xnu_syscall/bsd/impl/misc/clonefile.c
Outdated
Show resolved
Hide resolved
darling/src/libsystem_kernel/emulation/src/xnu_syscall/bsd/impl/misc/clonefile.c
Outdated
Show resolved
Hide resolved
darling/src/libsystem_kernel/emulation/src/xnu_syscall/bsd/impl/misc/clonefile.c
Outdated
Show resolved
Hide resolved
darling/src/libsystem_kernel/emulation/src/xnu_syscall/bsd/impl/misc/clonefile.c
Outdated
Show resolved
Hide resolved
jlucfarias
force-pushed
the
add-fclonefileat-syscall
branch
from
c425093 to
2244a32
Compare
Author
|
@CuriousTommy I think I fixed all comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first step to make rustup to work (current error can be seen in darling#1637)