ENH: various darshan-convert obfuscate fixes #1019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanedsnyder
commented
Mar 27, 2025
shanedsnyder
commented
- independent obfuscation flags to allow more control over what is obfuscated (e.g., to not obfuscate job ids)
- don't obfuscate common names like standard streams (e.g., ) or heatmaps
- independent obfuscation flags to allow more control over what is obfuscated (e.g., to not obfuscate job ids) - don't obfuscate common names like standard streams (e.g., <STDOUT>) or heatmaps
carns
requested changes
Mar 27, 2025
carns
left a comment
carns
left a comment
There was a problem hiding this comment.
Minor suggestion for how to handle the options. Otherwise looks good.
| fprintf(stderr, " Converts darshan log from infile to outfile.\n"); | ||
| fprintf(stderr, " rewrites the log file into the newest format.\n"); | ||
| fprintf(stderr, " --bzip2 Use bzip2 compression instead of zlib.\n"); | ||
| fprintf(stderr, " --obfuscate Obfuscate items in the log.\n"); |
There was a problem hiding this comment.
Would it be worth keeping --obfuscate for compatibility? (setting it would implicitly set each of the individual flags, so the comment/usage in that case would be something like "Enable all obfuscate options (jobid, uid, exe, and names)"
Author
There was a problem hiding this comment.
good call, i fixed this by adding back the original option that sets all flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.