BUG: correct DAOS and DFS layout in dataframe repacking that is consumed by the logutils accumulator API #1048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g problems with the accumulated metrics on pydarshan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating summary report from the Darshan logs containing DAOS module data, derived metrics like total_read_volume_bytes and total_write_volume_bytes were displaying incorrect values.
The issue was the pydarshan.backend.cffi_backend._df_to_rec utility function. It was using an incomplete NumPy dtype with missing several fields from the darshan_daos_object C struct (pool_uuid, cont_uuid, oid_hi, and oid_lo) when converting DAOS records to a C buffer of records that is consumed by the Darshan-util C code. Similar problem exists for the DFS module data.
This PR fixes the issue by updating the np.recarray dtype in _df_to_rec to include all fields for DAOS and DFS records.