add command-line option --version to print Darshan version #1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkliao
added
the
Work in Progress
carns
reviewed
Jul 11, 2025
darshan-util/darshan-parser.c
Outdated
| mask |= c; | ||
| break; | ||
| case OPTION_VERSION: | ||
| printf("%s\n",VERSION); |
There was a problem hiding this comment.
I don't know if it makes any difference in practice, but I think PACKAGE_VERSION is the more conventional macro to use here? Otherwise this looks good to me.
carns
previously approved these changes
Jul 11, 2025
Collaborator
Author
|
Please do not merge yet. |
wkliao
removed
the
Work in Progress
Collaborator
Author
|
Hi, @carns |
carns
approved these changes
Jul 12, 2025
carns
left a comment
carns
left a comment
There was a problem hiding this comment.
Looks good to me. I don't see any other utilities that aren't covered. Feel free to merge whenever you are ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--versioncommand-line option to all utility programs.This makes Darshan's users easier to query the version number.
An example output is: