-
Notifications
You must be signed in to change notification settings - Fork 37
darshan-config: add a complete list of options configured #1054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
20500d3 to
0fd7dfe
Compare
carns
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, much more thorough than I imagined! I just suggested one additional parameter that I didn't see in the list, because I've recently wished it were easier to see that particular option in someone's build.
darshan-runtime/darshan-config.in
Outdated
| echo " --pre-ld-flags -> $PRE_LD_FLAGS" | ||
| echo " --post-ld-flags -> $POST_LD_FLAGS" | ||
| echo " --dyn-ld-flags -> $DYN_LD_FLAGS" | ||
| echo " --log-path -> $DARSHAN_LOG_ALL" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about --with-log-path-by-env? I didn't thoroughly check if all options are represented here, but that one jumped out at me as an important one to see if it is set. It is a little bit of a frustrating option because I think there is a way to override it (even by configuration file) to go back to the conventional log path setup if it has been set. (that may be a separate issue to open; it catches a few Spack users because of the default Spack package options).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice that the value set in --with-log-path-by-env will appear
(pre-pended) in --log-path already. For example, if my configure
command is
configure --with-log-path=$HOME/Darshan/LOG \
--with-log-path-by-env=DARSHAN_LOG1,DARSHAN_LOG2
then, command darshan-config --log-path shows
$DARSHAN_LOG1,$DARSHAN_LOG2,/home/wliao/Darshan/LOG
See the source codes in
darshan/darshan-runtime/darshan-config.in
Lines 38 to 44 in b781182
| if [ "$DARSHAN_LOG_ENV" -a "$DARSHAN_LOG_PATH" ]; then | |
| DARSHAN_LOG_ALL="$DARSHAN_LOG_ENV,$DARSHAN_LOG_PATH" | |
| elif [ "$DARSHAN_LOG_ENV" ]; then | |
| DARSHAN_LOG_ALL=$DARSHAN_LOG_ENV | |
| else | |
| DARSHAN_LOG_ALL=$DARSHAN_LOG_PATH | |
| fi |
I think maybe separating them into two is better, less confusing, i.e.
--log-path -> /home/wliao/Darshan/LOG
--log-path-by-env -> $DARSHAN_LOG1,$DARSHAN_LOG2
And also remove the $ before the env variables?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I forgot they were combined. I agree that this is less confusing, thanks.
I don't have a preference for whether the $ is there or not. It was important when they were combined (to differentiate true paths from environment variables) but that doesn't matter if they are split.
carns
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this. I'll leave it to you to decide whether to include the $ character on the --log-path-by-env values. Otherwise you can merge when ready.
This PR is to enable
darshan-configutility program to show all configured options used when Darshan is built.Below are the changes when using this configure command:
Command
darshan-config --allnow shows all options used at Darshan's configure time.(click to expand)
Command
darshan-config --helpnow shows all available command-line options.(click to expand)