Skip to content

Add pthread id and extra_info support in DXT #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add pthread id and extra_info support in DXT #1066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e473845
Add "extra info" field to the records
roblatham00 Dec 14, 2016
9411c93
bug fix for read traces
Mar 28, 2024
4831637
remove unnecessary DXT printing code
Mar 28, 2024
88f807b
support for annotating DXT segment with pthread_id
Mar 29, 2024
8195bee
add pydarshan support for extra_info
Feb 17, 2025
35eaf82
bump up DXT_POSIX_VER to 2 and DXT_MPIIO_VER to 3
wkliao Nov 5, 2025
9890eb0
Check DXT_POSIX and DXT_MPIIO versions of input log file
wkliao Nov 5, 2025
3b83b2d
use the same constant name EXTRA_INFO_LEN as darshan-dxt-log-format.h
wkliao Nov 5, 2025
dd64f89
Check DXT_POSIX and DXT_MPIIO versions of input log file
wkliao Nov 5, 2025
341f12f
Take pthread_id out of extra_info[]
wkliao Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions darshan-runtime/lib/darshan-dxt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ static struct dxt_file_record_ref *dxt_posix_track_new_file_record(
darshan_record_id rec_id);
static struct dxt_file_record_ref *dxt_mpiio_track_new_file_record(
darshan_record_id rec_id);
static void annotate_trace_segment(char *extra_info_str);

/* DXT output/cleanup routines for darshan-core */
static void dxt_posix_output(
Expand Down Expand Up @@ -262,6 +263,8 @@ void dxt_posix_write(darshan_record_id rec_id, int64_t offset,
rec_ref->write_traces[file_rec->write_count].length = length;
rec_ref->write_traces[file_rec->write_count].start_time = start_time;
rec_ref->write_traces[file_rec->write_count].end_time = end_time;
rec_ref->write_traces[file_rec->write_count].pthread_id = (unsigned long)pthread_self();
annotate_trace_segment(rec_ref->write_traces[file_rec->write_count].extra_info);
file_rec->write_count += 1;

DXT_UNLOCK();
Expand Down Expand Up @@ -307,6 +310,8 @@ void dxt_posix_read(darshan_record_id rec_id, int64_t offset,
rec_ref->read_traces[file_rec->read_count].length = length;
rec_ref->read_traces[file_rec->read_count].start_time = start_time;
rec_ref->read_traces[file_rec->read_count].end_time = end_time;
rec_ref->read_traces[file_rec->read_count].pthread_id = (unsigned long)pthread_self();
annotate_trace_segment(rec_ref->read_traces[file_rec->read_count].extra_info);
file_rec->read_count += 1;

DXT_UNLOCK();
Expand Down Expand Up @@ -352,6 +357,8 @@ void dxt_mpiio_write(darshan_record_id rec_id, int64_t offset,
rec_ref->write_traces[file_rec->write_count].offset = offset;
rec_ref->write_traces[file_rec->write_count].start_time = start_time;
rec_ref->write_traces[file_rec->write_count].end_time = end_time;
rec_ref->write_traces[file_rec->write_count].pthread_id = (unsigned long)pthread_self();
annotate_trace_segment(rec_ref->write_traces[file_rec->write_count].extra_info);
file_rec->write_count += 1;

DXT_UNLOCK();
Expand Down Expand Up @@ -397,6 +404,8 @@ void dxt_mpiio_read(darshan_record_id rec_id, int64_t offset,
rec_ref->read_traces[file_rec->read_count].offset = offset;
rec_ref->read_traces[file_rec->read_count].start_time = start_time;
rec_ref->read_traces[file_rec->read_count].end_time = end_time;
rec_ref->read_traces[file_rec->read_count].pthread_id = (unsigned long)pthread_self();
annotate_trace_segment(rec_ref->read_traces[file_rec->read_count].extra_info);
file_rec->read_count += 1;

DXT_UNLOCK();
Expand Down Expand Up @@ -760,6 +769,18 @@ static struct dxt_file_record_ref *dxt_mpiio_track_new_file_record(
return(rec_ref);
}

static void annotate_trace_segment(char *extra_info_str)
{
char *extra_info_env = getenv("DARSHAN_DXT_EXTRA_INFO");
if (extra_info_env != NULL) {
strncpy(extra_info_str, extra_info_env, EXTRA_INFO_LEN-1);
} else {
extra_info_str[0] = '\0';
}

return;
}

static void dxt_free_record_data(void *rec_ref_p, void *user_ptr)
{
struct dxt_file_record_ref *dxt_rec_ref = (struct dxt_file_record_ref *)rec_ref_p;
Expand Down
Loading
Loading