Skip to content

avoid div by zero in cli tools when there is no I/O #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

avoid div by zero in cli tools when there is no I/O #1069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion darshan-util/pydarshan/darshan/cli/file_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,10 @@ def rich_print(df, mod, order_by):
# calculate totals to plug in to table footer
all_time_by_slowest = df["time_by_slowest"].sum()
all_total_bytes = df["total_bytes"].sum()
all_perf_by_slowest = all_total_bytes / all_time_by_slowest
if all_total_bytes == 0:
all_perf_by_slowest = 0
else:
all_perf_by_slowest = all_total_bytes / all_time_by_slowest
all_bytes_read = df["bytes_read"].sum()
all_bytes_written = df["bytes_written"].sum()
all_reads = df["reads"].sum()
Expand Down
5 changes: 4 additions & 1 deletion darshan-util/pydarshan/darshan/cli/job_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,10 @@ def rich_print(df, mod, order_by):
all_time_by_slowest = df['time_by_slowest'].sum()
all_total_bytes = df['total_bytes'].sum()
all_total_files = df['total_files'].sum()
all_perf_by_slowest = all_total_bytes / all_time_by_slowest
if all_total_bytes == 0:
all_perf_by_slowest = 0
else:
all_perf_by_slowest = all_total_bytes / all_time_by_slowest

# instantiate a rich table and pretty print the dataframe
console = Console()
Expand Down
Loading