WIP: test for numpy (dup via fcntl) not logging writes #1074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblatham00
force-pushed
the
dev-fcntl-dup-wrap
branch
4 times, most recently
from
afa2d74 to
af24070
Compare
roblatham00
force-pushed
the
dev-fcntl-dup-wrap
branch
from
af24070 to
7755a6a
Compare
Initially we are only going to log dup variants but we will eventually log fcntl locks as well.
Merged
wkliao
reviewed
Sep 23, 2025
Contributor
Author
|
I messed up separating the test from the implementation and both ended up in #1075 . will close this one and work over there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found yet another way to obtain a file descriptor...
I added the test first. This work in progress commit/request is just to make sure the test runs (and fails)