Setting --with-pnetcdf automatically enables enable_pnetcdf_mod

[wkliao]

When Darshan is configured using --with-pnetcdf=DIR without
--enable-pnetcdf-mod, the pnetcdf module will not be built.
However, in this case, it is clear that the user's intent is to enable pnetcdf.

This PR changes the behavior to automatically sets --enable-pnetcdf-mod
when --with-pnetcdf=DIR is used at the configure time.

Same for modules HDF5, DAOS, and LDMS.

[wkliao]

Hi, @carns

There are 2 additional ones, --with-daos=DIR and --with-ldms=DIR.
I wonder if it was designed that way and I am missing something here.

[carns]

Hi, @carns

There are 2 additional ones, --with-daos=DIR and --with-ldms=DIR. I wonder if it was designed that way and I am missing something here.

IIRC correctly, the --with-XYZ-mod options were all added at the same time to enable fine-grained control of which modules are activated, regardless of whether the corresponding libraries had been detected. This was important on some systems where libraries for a given file system or library were available but we didn't want to actually enable the module. The --with-XYZ options mostly predated that change, and were only meant to assist in detecting libraries (with whether they were activated or not being implied). So in other words, there wasn't really a coordinated plan for how these options worked together.

I think your observation that if someone explicitly provides a --with-XYZ (to detect a library) then it is natural to assume that they also want --with-XYZ-mod (to enable the corresponding module) is a good one. We just didn't think about coordinating these arguments before.

[wkliao]

OK. I added the similar changes for DAOS and LDMS.