add github actions for all non-ui packages #172
Conversation
|
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/dart_ci/+/433880 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
|
https://dart-review.googlesource.com/c/dart_ci/+/433880 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/dart_ci/+/433880 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/dart_ci/+/433880 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/dart_ci/+/433880 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/dart_ci/+/433880 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/dart_ci/+/433880 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/dart_ci/+/433880 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/dart_ci/+/433880 has been updated with the latest commits from this pull request. |
2 similar comments
|
https://dart-review.googlesource.com/c/dart_ci/+/433880 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/dart_ci/+/433880 has been updated with the latest commits from this pull request. |
|
|
||
| - run: dart format --output=none --set-exit-if-changed . | ||
|
|
||
| # TODO: Install gsutil and un-skip tests that require it |
There was a problem hiding this comment.
Probably the most accurate way to test this is to checkout depot_tools and put that into the path, that would be what users of baseline would do.
There was a problem hiding this comment.
Yeah, I would like to save that for a followup though, lots already to work through on this one to get it to this point
|
@athomas I will need you to merge this as well |
2 participants
I can follow up with some of the more complicated UI packages (flutter/angular apps).
I also had to skip many sets of tests for now just due to missing dependencies and such, I filed #173 to follow up on these. But, some testing is better than no testing for now.
EDIT: UI packages PR is here #174