Skip to content

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Oct 10, 2025

As it is done in the health workflow.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.

@mosuem mosuem requested a review from devoncarew October 10, 2025 14:29
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Oct 10, 2025
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

This check can be disabled by tagging the PR with skip-license-check.

@mosuem mosuem merged commit f4fbac4 into main Oct 13, 2025
12 checks passed
@mosuem mosuem deleted the newestFirehose branch October 13, 2025 09:07
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Oct 13, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ai (https://github.com/dart-lang/ai/compare/59db320..a29274b):
  a29274b  2025-10-09  Greg Spencer  Provide output logs when the process launch fails. (dart-lang/ai#293)
  d33ed02  2025-10-07  Greg Spencer  [Feat] Add hot restart tool (dart-lang/ai#297)

dartdoc (https://github.com/dart-lang/dartdoc/compare/ec2a4fe..98d03ad):
  98d03ad2  2025-10-09  Sarah Zakarias  Bump to 9.0.0 (dart-lang/dartdoc#4116)
  45ba6ede  2025-10-07  Sam Rawlins  Display constructor names in annotations (dart-lang/dartdoc#4115)

ecosystem (https://github.com/dart-lang/ecosystem/compare/96ee861..f4fbac4):
  f4fbac4  2025-10-13  Moritz  Use up to date firehose in publish (dart-lang/ecosystem#376)
  1fe5686  2025-10-10  Moritz  Relax assumptions on workspaces in firehose (dart-lang/ecosystem#375)

shelf (https://github.com/dart-lang/shelf/compare/f30d650..710b8ce):
  710b8ce  2025-10-08  Kevin Moore  shelf_router_generator: update dependencies, SDK (dart-lang/shelf#484)

tools (https://github.com/dart-lang/tools/compare/6866f9b..adf3fe7):
  adf3fe78  2025-10-13  Parker Lougheed  [markdown] Preserve metadata passed to fenced code blocks (dart-lang/tools#2186)
  b435a46b  2025-10-10  Stephen Adams  Fix `SingleMapping.spanFor` to use previous line (dart-lang/tools#2205)
  4c7dae18  2025-10-10  Morgan :)  Fix for skipped tests on Windows. (dart-lang/tools#2204)
  50b4514e  2025-10-09  Morgan :)  Use Event extension type for Windows DirectoryWatcher. (dart-lang/tools#2203)
  a0af8b59  2025-10-08  Morgan :)  Use Event extension type for MacOS DirectoryWatcher. (dart-lang/tools#2201)
  0f50f061  2025-10-08  Morgan :)  Add package-private extension type Event on FileSystemEvent. (dart-lang/tools#2200)
  d67ab97c  2025-10-07  Moritz  [bazel_worker] Upgrade `protobuf` + cleanups (dart-lang/tools#2195)

webdev (https://github.com/dart-lang/webdev/compare/29ba1b1..186bfe7):
  186bfe71  2025-10-09  Ben Konyi  [ DWDS ] Expose `dtdUri` via `DebugConnection` (dart-lang/webdev#2694)
  3ab8fca3  2025-10-09  Srujan Gaddam  [DWDS] Don't send PauseInterrupted event during a hot reload (dart-lang/webdev#2695)
  cdc5cc3c  2025-10-09  jensjoha  Pass script uri for javascript expression compilation (dart-lang/webdev#2682)

Change-Id: Ie78adfec4a8887af1ea3104b50c52ea2fd3bb1d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/454621
Reviewed-by: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-infra A repository infrastructure change or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants