Add Tunisian Arabic (ar_TN) localization support to intl package

[mohamed-yahyaoui]

Summary

This PR adds support for the Tunisian Arabic (ar_TN) locale to the intl package.

• Added ar_TN.json files for date symbols and date patterns
• Updated locale_list to include ar_TN
• Added date, number, and compact number symbols for ar_TN
• Updated plural rules to support ar_TN
• Added test data for number and compact number formatting for ar_TN
• Verified formatting and pluralization for the new locale

Testing
Ran example code with Intl.defaultLocale = 'tk' and confirmed correct formatting
Called initializeDateFormatting('tk', null) and verified no errors

Notes

Please let me know if any additional data or changes are needed.

[gemini-code-assist]

Summary of Changes

Hello @mohamed-yahyaoui, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive localization support for Tunisian Arabic (ar_TN) into the intl package. It integrates all necessary cultural data for date, time, and number formatting, along with appropriate pluralization rules. This addition enables applications to accurately display and format content for users in Tunisia, enhancing the package's global reach and user experience.

Highlights

• New Locale Support: Tunisian Arabic (ar_TN) has been added as a supported locale, expanding the internationalization capabilities of the intl package.
• Comprehensive Localization Data: Full date symbols, date/time patterns, and number formatting symbols specific to ar_TN have been integrated, ensuring accurate cultural representation.
• Plural Rules Integration: The ar_TN locale now correctly applies Arabic pluralization rules, which are essential for grammatically correct localized text.
• Enhanced Test Coverage: New test data for number and compact number formatting has been included for ar_TN, verifying the correctness of the newly added localization features.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds localization support for Tunisian Arabic (ar_TN), which is a valuable contribution. The changes include new data for date/time symbols, number formatting, and pluralization rules, along with corresponding tests.

My review has identified a few issues that need attention:

• The new keyword is used in a few places, which goes against Effective Dart style guidelines.
• The currency code for ar_TN is incorrect.
• Most importantly, the compact number symbols for ar_TN are missing, even though tests for them have been added.

Additionally, there's a small typo in the PR description where 'tk' is mentioned instead of 'ar_TN'.

Once these issues are addressed, this PR will be in great shape. Thank you for your work on this!

[gemini-code-assist]

These tests for ar_TN compact number formatting are a great addition. However, the corresponding compact number symbols for ar_TN are missing from the compactNumberSymbols map in pkgs/intl/lib/number_symbols_data.dart. Without this, the tests will fall back to the ar locale, which may not have the correct Tunisian-specific formats. Please add an entry for ar_TN to the compactNumberSymbols map.

[gemini-code-assist]

The DEF_CURRENCY_CODE should be the ISO 4217 code. For the Tunisian Dinar, the correct code is TND, not DT.

      DEF_CURRENCY_CODE: 'TND'),

[gemini-code-assist]

According to the Effective Dart style guide, the new keyword is unnecessary and should be avoided.¹ Please remove it.

      "ar_TN": DateSymbols(

Style Guide References

Footnotes

1. Effective Dart recommends avoiding the new keyword for constructors. ↩

[gemini-code-assist]

The new keyword is unnecessary here and should be removed to follow Effective Dart style guidelines.¹

  "ar_TN": NumberSymbols(

Style Guide References

Footnotes

1. Effective Dart recommends avoiding the new keyword for constructors. ↩

[mosuem]

The i18n data is pulled from CLDR data - so please file a PR there, or, if the data is already present, open an issue here to add this locale to the list of supported locales.

Do keep in mind that we are currently trying out package:intl4x as a replacement to package:intl - so if that fits your needs, there might be no need for this request at all.