Add support for Cloud Tasks#282
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
devoncarew
left a comment
devoncarew
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I made a few review comments, but don't have enough context to say whether this is an API we want (or what it should look like).
cc'ing @sigurdm and the @dart-lang/dart-pub-team generally for thoughts.
| @@ -0,0 +1,68 @@ | |||
| /// This library provides a low-level API for accessing Google's Cloud | |||
There was a problem hiding this comment.
Can you add the std 3-line copyright header here? For 2025.
| @@ -0,0 +1,47 @@ | |||
| import 'dart:convert'; | |||
There was a problem hiding this comment.
3-line copyright header
| @@ -0,0 +1,65 @@ | |||
| import 'dart:convert'; | |||
| /// If [name] is provided, the task will be given that name. | ||
| /// | ||
| /// Returns a [Future] which completes with the newly created task. | ||
| Future<tasks.Task> createTask( |
There was a problem hiding this comment.
I wonder if we should wrap the Task type in a more opinionated wrapper, such that we don't expose the types from package:googleapis.
Like we do here
labs/pkgs/gcloud/lib/src/storage_impl.dart
Line 128 in cda0362
| @@ -0,0 +1,68 @@ | |||
| /// This library provides a low-level API for accessing Google's Cloud | |||
There was a problem hiding this comment.
nit: can we call the file tasks.dart instead of cloud_tasks.dart (to align with storage.dart etc.)
| @@ -1,3 +1,7 @@ | |||
| ## 0.10.0 | |||
|
|
|||
| - Add support for Cloud Tasks | |||
There was a problem hiding this comment.
We need to also update the README.md
3 participants
Adds minimal Cloud Tasks support (creating a task with an http request).
I'm not sure if this is built out enough to warrant merging, and I imagine documentation updates would be required as well. lmk what you think!
Contribution guidelines:
dart format.Many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.
Note: The Dart team is trialing Gemini Code Assist. Don't take its comments as final Dart team feedback. Use the suggestions if they're helpful; otherwise, wait for a human reviewer.