[appengine] Name Exception subclasses with the Exception suffix#328
Open
martin-dehlan wants to merge 1 commit into
Open
[appengine] Name Exception subclasses with the Exception suffix#328martin-dehlan wants to merge 1 commit into
Exception suffix#328martin-dehlan wants to merge 1 commit into
Conversation
Types implementing `Exception` are conventionally named `*Exception`, but the appengine error types were named `*Error`. Rename them to `AppEngineException`, `NetworkException`, `ProtocolException`, `ServiceException` and `ApplicationException`. The old `*Error` names are kept as deprecated type aliases so the change is non-breaking, as suggested in the issue. Fixes dart-lang#99
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@googlebot I signed it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99.
Types implementing
Exceptionare conventionally named*Exception, but the appengine error types were named*Error. This renames them:AppEngineError→AppEngineExceptionNetworkError→NetworkExceptionProtocolError→ProtocolExceptionServiceError→ServiceExceptionApplicationError→ApplicationExceptionThe old
*Errornames are retained as@Deprecatedtype aliases, so the change is non-breaking — as suggested by @sigurdm in the issue. Internal references and test matchers are updated to the new names; the unrelatedpackage:gcloudApplicationErrorreferences are left untouched.dart analyzereports no issues anddart formatis clean. Added a CHANGELOG entry and bumped the version to0.13.13-wip.