Skip to content

Move language spec upload from Github actions to cloud build: Add cloudbuild.yaml#4323

Merged
eernstg merged 31 commits into
mainfrom
cloud_build_apr25
May 28, 2025
Merged

Move language spec upload from Github actions to cloud build: Add cloudbuild.yaml#4323
eernstg merged 31 commits into
mainfrom
cloud_build_apr25

Conversation

@eernstg
Copy link
Copy Markdown
Member

@eernstg eernstg commented Apr 10, 2025

This PR adds a 'cloudbuild.yaml' specification file to the language repository such that the provision of a PDF of the language specification can be achieved via a Cloud Build.

This change will not make anything happen, but it enables a Cloud Build trigger to make the build happen.

@eernstg eernstg requested a review from athomas April 10, 2025 12:29
@parlough
Copy link
Copy Markdown
Member

parlough commented Apr 15, 2025

I'm not sure if it makes sense or helps, but could the deploy from this repo also use the image created in https://github.com/dart-lang/site-shared/tree/main/cloud_build/firebase-ghcli? We could add the various latex tools needed to that.

@eernstg
Copy link
Copy Markdown
Member Author

eernstg commented Apr 16, 2025

use the image created in https://github.com/dart-lang/site-shared/tree/main/cloud_build/firebase-ghcli?

Sounds good! The image could presumably be extended at any time (like ASAP ;-) and then the script used in this PR could rely on having the LaTeX software available, right?

@eernstg eernstg force-pushed the cloud_build_apr25 branch from 38dd6cf to 3c2d6c3 Compare May 14, 2025 12:23
Comment thread .cloud_build/specification/cloudbuild.yaml Outdated
Comment thread specification/scripts/build_pdf Outdated
@eernstg
Copy link
Copy Markdown
Member Author

eernstg commented May 23, 2025

Perhaps the -m option is not accepted, and also not necessary?

@eernstg eernstg merged commit 5e6c780 into main May 28, 2025
5 of 7 checks passed
@eernstg eernstg deleted the cloud_build_apr25 branch May 28, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants