-
Notifications
You must be signed in to change notification settings - Fork 80
[hooks_runner] [hooks] Shorten output dir paths #2682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR Health
Breaking changes
|
Package | Change | Current Version | New Version | Needed Version | Looking good? |
---|---|---|---|---|---|
hooks | None | 0.20.1 | 0.20.2 | 0.20.1 | ✔️ |
hooks_runner | Breaking | 0.23.0 | 0.23.1 | 0.24.0 Got "0.23.1" expected >= "0.24.0" (breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check
.
Changelog Entry ✔️
Package | Changed Files |
---|
Changes to files need to be accounted for in their respective changelogs.
This check can be disabled by tagging the PR with skip-changelog-check
.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
Package | Leaked API symbol | Leaking sources |
---|
This check can be disabled by tagging the PR with skip-leaking-check
.
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files |
---|
no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
Files |
---|
pkgs/objective_c/lib/src/ns_input_stream.dart |
This check can be disabled by tagging the PR with skip-license-check
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pkgs/hooks/lib/src/config.dart
Outdated
/// This directory is unique per hook and per [config]. | ||
/// This directory is unique per hook and per [config]. The directory is | ||
/// nested inside [outputDirectoryShared] and has a short checksum to avoid | ||
/// running out of path lenght on Winddows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: lenght
pkgs/hooks/lib/src/config.dart
Outdated
/// nested inside [outputDirectoryShared] and has a short checksum to avoid | ||
/// running out of path lenght on Winddows. | ||
/// | ||
/// Note: Prefer using a sub directory of [outputDirectoryShared] with a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: drop the "note:", doesn't seem to add anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as below, document why this is preferred?
pkgs/hooks/lib/src/config.dart
Outdated
/// placed. | ||
/// | ||
/// This directory is unique per hook. | ||
/// This directory is unique per hook. Using a sub directory of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second "sentence" seems to be incomplete. Maybe you meant "use" instead of "using"? It's also a little unclear why I should be doing that. Can you document the motivation for why it is preferred to create a subdirectory with the checksum over the relevant parts of the configuration? What do I get out of it?
Closes: #2650
10 hex characters should be enough with up to 1000 configs.