Skip to content

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Oct 8, 2025

Closes: #2650

10 hex characters should be enough with up to 1000 configs.

Copy link

github-actions bot commented Oct 8, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:code_assets 0.19.7 already published at pub.dev
package:data_assets 0.19.3 already published at pub.dev
package:ffi 2.1.5-wip WIP (no publish necessary)
package:hooks 0.20.2 ready to publish hooks-v0.20.2
package:hooks_runner 0.23.1 ready to publish hooks_runner-v0.23.1
package:native_doc_dartifier 0.0.1-pre already published at pub.dev
package:native_toolchain_c 0.17.2 already published at pub.dev
package:swift2objc 0.1.0 already published at pub.dev
package:swiftgen 0.1.1 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link

github-actions bot commented Oct 8, 2025

PR Health

Breaking changes ⚠️
Package Change Current Version New Version Needed Version Looking good?
hooks None 0.20.1 0.20.2 0.20.1 ✔️
hooks_runner Breaking 0.23.0 0.23.1 0.24.0
Got "0.23.1" expected >= "0.24.0" (breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

@coveralls
Copy link

Coverage Status

coverage: 80.804%. remained the same
when pulling 057744c on shorter-paths
into 29cf243 on main.

@coveralls
Copy link

coveralls commented Oct 8, 2025

Coverage Status

coverage: 80.804%. remained the same
when pulling faf7d0e on shorter-paths
into 29cf243 on main.

Copy link
Contributor

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/// This directory is unique per hook and per [config].
/// This directory is unique per hook and per [config]. The directory is
/// nested inside [outputDirectoryShared] and has a short checksum to avoid
/// running out of path lenght on Winddows.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: lenght

/// nested inside [outputDirectoryShared] and has a short checksum to avoid
/// running out of path lenght on Winddows.
///
/// Note: Prefer using a sub directory of [outputDirectoryShared] with a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: drop the "note:", doesn't seem to add anything.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as below, document why this is preferred?

/// placed.
///
/// This directory is unique per hook.
/// This directory is unique per hook. Using a sub directory of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second "sentence" seems to be incomplete. Maybe you meant "use" instead of "using"? It's also a little unclear why I should be doing that. Can you document the motivation for why it is preferred to create a subdirectory with the checksum over the relevant parts of the configuration? What do I get out of it?

@dcharkes dcharkes merged commit e3fe811 into main Oct 8, 2025
21 checks passed
@dcharkes dcharkes deleted the shorter-paths branch October 8, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[hooks_runner] Shorten paths (for Windows)

3 participants