Skip to content

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Oct 9, 2025

Add library dartdoc comments that detail the main entry points for browsing the documentation of both packages.

Bug:

Copy link

github-actions bot commented Oct 9, 2025

PR Health

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

@coveralls
Copy link

coveralls commented Oct 9, 2025

Coverage Status

coverage: 81.229% (+0.001%) from 81.228%
when pulling 15fe85f on library-docs
into c76ea57 on main.

Copy link
Contributor

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/// application.
///
/// Code assets can be added in a build hook as follows:
/// [CodeAsset] can be added to the [BuildOutputBuilder] a build hook as
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe:

Suggested change
/// [CodeAsset] can be added to the [BuildOutputBuilder] a build hook as
/// A [CodeAsset] can be added to the [BuildOutputBuilder] in a build hook as

Copy link

auto-submit bot commented Oct 10, 2025

autosubmit label was removed for dart-lang/native/2687, because - The status or check suite health / breaking / run breaking health check has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dcharkes
Copy link
Collaborator Author

I believe the CI breakage is due to dart-lang/ecosystem#375, skipping check.

@dcharkes dcharkes merged commit 6fe224f into main Oct 10, 2025
46 of 50 checks passed
@dcharkes dcharkes deleted the library-docs branch October 10, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants