Skip to content

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Oct 9, 2025

Make the examples/README.md of package:hooks point to the examples from package:code_assets.

Note: I don't know if the relative paths to outside the package work properly, if not we'll need to use absolute URLs.

Bug:

@coveralls
Copy link

Coverage Status

coverage: 81.228%. remained the same
when pulling 5724cb5 on hooks-examples
into c76ea57 on main.

Copy link

github-actions bot commented Oct 9, 2025

PR Health

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

Copy link
Contributor

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcharkes dcharkes merged commit f9ff96e into main Oct 10, 2025
33 of 35 checks passed
@dcharkes dcharkes deleted the hooks-examples branch October 10, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants