Skip to content

Conversation

dcharkes
Copy link
Collaborator

I'm not convinced that we'll keep the current API (a file path) for record use.

  • We might want to simply have the Dart API directly. (Possibly async via a future. Possibly as an extension method on top of the LinkInput in package:record_use.)

Let's just mark it experimental for now, then we are allowed to change it and break people who rely on it.

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
hooks None 0.20.2 0.20.2 0.20.2 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

1 similar comment
Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
hooks None 0.20.2 0.20.2 0.20.2 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

@auto-submit auto-submit bot merged commit c4066ea into main Oct 10, 2025
36 checks passed
@auto-submit auto-submit bot deleted the mark-experiment branch October 10, 2025 08:58
@coveralls
Copy link

Coverage Status

coverage: 81.229% (+0.001%) from 81.228%
when pulling 8f12384 on mark-experiment
into c76ea57 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants