-
Notifications
You must be signed in to change notification settings - Fork 80
[jni] Swap CRITICAL_SECTION
with SRWLOCK
#2699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with |
1 similar comment
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with |
typedef SRWLOCK MutexLock; | ||
typedef CONDITION_VARIABLE ConditionVariable; | ||
|
||
static inline void init_lock(MutexLock* lock) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two files really need cleanup they are very messy and don't follow Google C++ Style Guide. Ignore this for now though.
(e.g. why is it static inline
in the header? Should be just inline
. The name should be InitLock
. It should be in the namespace. dartjni.c
should be dartjni.cc
, etc).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #2701
Swap
CRITICAL_SECTION
withSRWLOCK
on Windows as it doesn't require init/deinit inDllMain
anymore.Close #2698.